Skip to content

Conversation

@SNiemann15
Copy link
Contributor

@SNiemann15 SNiemann15 commented Jun 12, 2025

Version(s): 4.19+

Issue: CNV-52363

Link to docs preview: https://94672--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/install/preparing-cluster-for-virt.html#supported-platforms_preparing-cluster-for-virt

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 12, 2025
@SNiemann15
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2025
@SNiemann15
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 12, 2025
@ousleyp
Copy link
Member

ousleyp commented Jun 12, 2025

LGTM

@ousleyp ousleyp added peer-review-done Signifies that the peer review team has reviewed this PR CNV Label for all CNV PRs branch/enterprise-4.19 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 12, 2025
@ousleyp ousleyp added this to the Planned for 4.19 GA milestone Jun 12, 2025
@LakshmiRavichandran1
Copy link

lgtm

@SNiemann15 SNiemann15 force-pushed the ocpvirt_back_to_tp branch from bf7e8fc to 51fdd69 Compare June 13, 2025 10:37
@SNiemann15
Copy link
Contributor Author

Adding bullets from this PR: #94343

Depending on GA or TP only one of the two needs to get merged.

@LakshmiRavichandran1
Copy link

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jun 13, 2025

@LakshmiRavichandran1: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SNiemann15 SNiemann15 force-pushed the ocpvirt_back_to_tp branch from 51fdd69 to 23294a9 Compare June 13, 2025 12:35
@openshift-ci
Copy link

openshift-ci bot commented Jun 13, 2025

@SNiemann15: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ousleyp
Copy link
Member

ousleyp commented Jun 13, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2025
@ousleyp
Copy link
Member

ousleyp commented Jun 13, 2025

LGTM!

@ousleyp ousleyp merged commit 4bfa979 into openshift:main Jun 13, 2025
2 checks passed
@ousleyp
Copy link
Member

ousleyp commented Jun 13, 2025

/cherrypick enterprise-4.19

@openshift-cherrypick-robot

@ousleyp: new pull request created: #94780

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.19 CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants