Skip to content

OADP Authentication with Azure #96739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shdeshpa07 merged 1 commit into from
Sep 23, 2025
Merged

OADP Authentication with Azure #96739

shdeshpa07 merged 1 commit into from
Sep 23, 2025

Conversation

@shdeshpa07
Copy link
Contributor

@shdeshpa07 shdeshpa07 commented Jul 28, 2025 •
edited
Loading

Jira

OADP Authentication with Azure

Version

  • OCP 4.19 → OCP 4.20

Preview

QE Review

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 28, 2025
@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Jul 28, 2025

/label OADP

@openshift-ci openshift-ci bot added the OADP Label for all OADP PRs label Jul 28, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 28, 2025 •
edited
Loading

🤖 Tue Sep 23 06:35:25 - Prow CI generated the docs preview:

https://96739--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-aws.html
https://96739--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-azure.html
https://96739--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-gcp.html
https://96739--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-ibm-cloud.html
https://96739--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-kubevirt.html
https://96739--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-mcg.html
https://96739--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-ocs.html
https://96739--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/backup_restore/virt-backup-restore-overview.html
https://96739--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/virt/backup_restore/virt-backup-restore-overview.html
https://96739--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/backup_restore/virt-backup-restore-overview.html

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 30, 2025
@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Aug 1, 2025

@weshayutin @PrasadJoshi12 - I have made changes in the Azure config docs to use either the service principal or storage account access keys. Could you please review the PR? Thanks.

@weshayutin
Copy link

weshayutin commented Aug 1, 2025

@akarol whomever is testing @kaovilai's standard auth issues for 1.5.1 should also validate the azure, gcp docs for the short term token setup in each cloud. @shdeshpa07 let's be a little patient here, and allow use to get a build out to QE w/ the latest changes and then we'll rewalk the doc here. Incidentally it looks good to me.

@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Aug 4, 2025

@akarol whomever is testing @kaovilai's standard auth issues for 1.5.1 should also validate the azure, gcp docs for the short term token setup in each cloud. @shdeshpa07 let's be a little patient here, and allow use to get a build out to QE w/ the latest changes and then we'll rewalk the doc here. Incidentally it looks good to me.

Thanks @weshayutin. Yes, this config section needs the Azure AD Workload Identity way of auth. We may want to create a separate section for it. Like you said, we can discuss this when the testing is underway.

@akarol
Copy link

akarol commented Aug 4, 2025

@weshayutin I'll make sure the Azure and GCP short-term token setup and documentation are validated alongside the standard auth testing for 1.5.1.

@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 12, 2025
@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Sep 15, 2025

@stillalearner @weshayutin @kaovilai - Can I request reviews on this PR please?

I have added 2 new sections for the 2 Azure auth methods:

Using OADP with Azure STS auth

Using OADP with Azure Workload Identity

Thanks.

weshayutin
weshayutin approved these changes Sep 15, 2025
View reviewed changes
Copy link

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaovilai please review

kaovilai
kaovilai suggested changes Sep 15, 2025
View reviewed changes
Copy link
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kaovilai/oadp-operator/blob/cloudstorageAPI-docs/docs/config/azure/oadp-azure-sts-cloud-authentication.adoc

has more up to date docs, please check for removals and additions.

@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Sep 16, 2025

https://github.com/kaovilai/oadp-operator/blob/cloudstorageAPI-docs/docs/config/azure/oadp-azure-sts-cloud-authentication.adoc

has more up to date docs, please check for removals and additions.

@kaovilai - I have done the changes. Could you please have a look again. Thanks.

stillalearner
stillalearner reviewed Sep 17, 2025
View reviewed changes
stillalearner
stillalearner reviewed Sep 17, 2025
View reviewed changes
stillalearner
stillalearner reviewed Sep 17, 2025
View reviewed changes
stillalearner
stillalearner reviewed Sep 17, 2025
View reviewed changes
stillalearner
stillalearner reviewed Sep 17, 2025
View reviewed changes
stillalearner
stillalearner reviewed Sep 17, 2025
View reviewed changes
stillalearner
stillalearner reviewed Sep 17, 2025
View reviewed changes
kaovilai
kaovilai suggested changes Sep 18, 2025
View reviewed changes
@shdeshpa07 shdeshpa07 changed the title OADP Authentication OADP with Azure OADP Authentication with Azure Sep 18, 2025
stillalearner
stillalearner reviewed Sep 18, 2025
View reviewed changes
@weshayutin
Copy link

weshayutin commented Sep 18, 2025

@anarnold97 can you please ensure this is written in modules that can be shared w/ the ARO team like we have shared doc w/ the ROSA team please. THANK YOU!

@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Sep 18, 2025

@anarnold97 can you please ensure this is written in modules that can be shared w/ the ARO team like we have shared doc w/ the ROSA team please. THANK YOU!

Hey Wes, yes it is written in modules :).

kaovilai
kaovilai reviewed Sep 18, 2025
View reviewed changes
@openshift-ci openshift-ci bot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 19, 2025
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 19, 2025
@weshayutin
Copy link

weshayutin commented Sep 19, 2025

@shdeshpa07 not sure how docs team should intersect w/ mobb doc. For your reference
rh-mobb/documentation#659

@anarnold97
Copy link
Contributor

anarnold97 commented Sep 19, 2025

@shdeshpa07 not sure how docs team should intersect w/ mobb doc. For your reference rh-mobb/documentation#659

@shdeshpa07 & @weshayutin - leave this with me

@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Sep 22, 2025

@vashirova - Can I request your peer review on this PR please? Thanks.

vashirova
vashirova approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@vashirova vashirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shdeshpa07 peer review is completed. Brilliant work overall, thanks for the opportunity!

@shdeshpa07
OADP Authentication OADP with Azure
598cf04 
Signed-off-by: Shruti Deshpande <shdeshpa@redhat.com>
@shdeshpa07 shdeshpa07 force-pushed the OADP-Authentication-OADP-with-Azure branch from 0669569 to 598cf04 Compare September 23, 2025 06:29
@openshift-ci
Copy link

openshift-ci bot commented Sep 23, 2025

@shdeshpa07: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shdeshpa07 shdeshpa07 added this to the Continuous Release milestone Sep 23, 2025
@shdeshpa07 shdeshpa07 merged commit 48544c2 into openshift:main Sep 23, 2025
2 checks passed
@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Sep 23, 2025

/cherrypick enterprise-4.20

@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Sep 23, 2025

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 23, 2025

@shdeshpa07: new pull request created: #99531

Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 23, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 23, 2025

@shdeshpa07: new pull request created: #99532

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 23, 2025
Merged
@shdeshpa07 shdeshpa07 mentioned this pull request Sep 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@kaovilai kaovilai kaovilai requested changes

@stillalearner stillalearner stillalearner left review comments

@weshayutin weshayutin weshayutin approved these changes

@vashirova vashirova vashirova approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.19 branch/enterprise-4.20 OADP Label for all OADP PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

9 participants

@shdeshpa07 @ocpdocs-previewbot @weshayutin @akarol @anarnold97 @openshift-cherrypick-robot @kaovilai @stillalearner @vashirova