Skip to content

Migrate away from deprecated ioutil#362

Open
sebrandon1 wants to merge 1 commit intoopenshift:oadp-devfrom
sebrandon1:ioutil_deprecation
Open

Migrate away from deprecated ioutil#362
sebrandon1 wants to merge 1 commit intoopenshift:oadp-devfrom
sebrandon1:ioutil_deprecation

Conversation

@sebrandon1
Copy link
Member

@sebrandon1 sebrandon1 commented Nov 24, 2025

ioutil has been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutil

Tracking issue: redhat-best-practices-for-k8s/telco-bot#52

Summary by CodeRabbit

  • Chores
    • Updated internal code for compatibility with newer Go versions

@coderabbitai
Copy link

coderabbitai bot commented Nov 24, 2025

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between dc8e5dc and 87600bb.

📒 Files selected for processing (1)
  • velero-plugins/util/test/test_logger.go

Walkthrough

Replaces the io/ioutil import with io and updates logger.Out from ioutil.Discard to io.Discard in a Go test file; no other API or behavioral changes.

Changes

Cohort / File(s) Summary
Deprecation Update
velero-plugins/util/test/test_logger.go
Replace io/ioutil import with io and set logger.Out from ioutil.Discard to io.Discard.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Migrate away from deprecated ioutil' accurately and directly reflects the main change in the pull request, which updates code to remove the deprecated Go package ioutil.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Stable And Deterministic Test Names ✅ Passed The custom check for stable test names is not applicable to this PR, which contains only dependency modernization changes (ioutil to io imports) with no modifications to test naming or structure.
Test Structure And Quality ✅ Passed The modified file is a utility/helper module, not a test file, containing only a single helper function for creating loggers with no test structure elements.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link

openshift-ci bot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, sebrandon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2025
@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2026

@sebrandon1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-test 87600bb link true /test unit-test
ci/prow/images 87600bb link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants