NO-JIRA: enhance-waitnodeready-util #30377

huali9 · 2025-10-14T04:13:25Z

Add https://github.com/openshift/openshift-tests-private/pull/26443 also to origin repo. It's for improving WaitForNodesReady func.
I have tested in my local and it works. @rioliu-rh PTAL, thanks!

liuhuali@Lius-MacBook-Pro openshift-tests-private % ./bin/extended-platform-tests run all --dry-run --timeout 60m |grep 22612 |./bin/extended-platform-tests run -f -
  I1014 10:57:41.720836 5884 test.go:180] Found authentication type used: 
  I1014 10:57:41.721151 5884 test_context.go:566] The --provider flag is not set. Continuing as if --provider=skeleton had been used.
  I1014 10:57:43.600010 5884 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get node -l node-role.kubernetes.io/worker -o=jsonpath={.items[*].metadata.name}'
  I1014 10:57:45.476351 5884 api.go:57] EnvIsKubernetesCluster = no, start monitoring ClusterOperators and ClusterVersions
started: (0/1/1) "[sig-cluster-lifecycle] Cluster_Infrastructure Upgrade Author:zhsun-NonHyperShiftHOST-NonPreRelease-PstChkUpgrade-LEVEL0-Critical-22612-Cluster could scale up/down after upgrade [Disruptive] [Serial][Slow]"

  I1014 10:58:00.523685 5891 openshift-tests.go:203] Is kubernetes cluster: no, is external OIDC cluster: no
  I1014 10:58:00.524060 5891 test_context.go:566] The --provider flag is not set. Continuing as if --provider=skeleton had been used.
  I1014 10:58:01.013788 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get node -l node-role.kubernetes.io/worker -o=jsonpath={.items[*].metadata.name}'
  [1760410665] openshift extended e2e - 1/1 specs I1014 10:58:07.528691 5891 client.go:288] configPath is now "/var/folders/yc/y9zy01jn3f51r9knbpsm_55r0000gn/T/configfile2219945927"
  I1014 10:58:07.528754 5891 client.go:363] The user is now "e2e-test-cluster-infrastructure-upgrade-t45r4-user"
  I1014 10:58:07.528766 5891 client.go:365] Creating project "e2e-test-cluster-infrastructure-upgrade-t45r4"
  I1014 10:58:08.884197 5891 client.go:373] Waiting on permissions in project "e2e-test-cluster-infrastructure-upgrade-t45r4" ...
  I1014 10:58:09.981365 5891 client.go:402] DeploymentConfig capability is enabled, adding 'deployer' SA to the list of default SAs
  I1014 10:58:10.254615 5891 client.go:417] Waiting for ServiceAccount "default" to be provisioned...
  I1014 10:58:10.898909 5891 client.go:417] Waiting for ServiceAccount "builder" to be provisioned...
  I1014 10:58:11.543415 5891 client.go:417] Waiting for ServiceAccount "deployer" to be provisioned...
  I1014 10:58:12.191637 5891 client.go:427] Waiting for RoleBinding "system:image-pullers" to be provisioned...
  I1014 10:58:12.732472 5891 client.go:427] Waiting for RoleBinding "system:image-builders" to be provisioned...
  I1014 10:58:13.269252 5891 client.go:427] Waiting for RoleBinding "system:deployers" to be provisioned...
  I1014 10:58:14.331297 5891 client.go:460] Project "e2e-test-cluster-infrastructure-upgrade-t45r4" has been fully provisioned.
  I1014 10:58:14.331982 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get node -l node-role.kubernetes.io/master -o jsonpath='{.items[*].metadata.name}''
  I1014 10:58:15.901391 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get node -l node-role.kubernetes.io/worker -o jsonpath='{.items[*].metadata.name}''
  I1014 10:58:27.367532 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get infrastructure cluster -o=jsonpath={.status.platformStatus.type}'
  I1014 10:58:28.297175 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machines.machine.openshift.io --no-headers -n openshift-machine-api'
  I1014 10:58:34.089408 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get infrastructure cluster -o=jsonpath={.status.platformStatus.type}'
  I1014 10:58:45.008387 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get infrastructure cluster -o=jsonpath={.status.infrastructureName}'
  I1014 10:58:46.039663 5891 machine_helpers.go:39] Creating a new MachineSets ...
  I1014 10:58:46.039885 5891 machine_helpers.go:188] Getting a random MachineSet ...
  I1014 10:58:46.040542 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get infrastructure cluster -o=jsonpath={.status.platformStatus.type}'
  I1014 10:58:56.982362 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get nodes -l node-role.kubernetes.io/worker --show-labels'
  I1014 10:58:58.369809 5891 machine_helpers.go:78] Listing all MachineSets ...
  I1014 10:58:58.370390 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machinesets.machine.openshift.io -o=jsonpath={.items[*].metadata.name} -n openshift-machine-api'
  I1014 10:59:04.406372 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machinesets.machine.openshift.io shudi-21a14-qnrp9-worker-us-east-2a -o=jsonpath={.spec.template.metadata.labels} -n openshift-machine-api'
  I1014 10:59:20.424822 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machinesets.machine.openshift.io shudi-21a14-qnrp9-worker-us-east-2b -o=jsonpath={.spec.template.metadata.labels} -n openshift-machine-api'
  I1014 10:59:26.077168 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machinesets.machine.openshift.io shudi-21a14-qnrp9-worker-us-east-2c -o=jsonpath={.spec.template.metadata.labels} -n openshift-machine-api'
  I1014 10:59:31.642222 5891 machine_helpers.go:93] linuxWorkerMachineSetNames: [shudi-21a14-qnrp9-worker-us-east-2a shudi-21a14-qnrp9-worker-us-east-2b shudi-21a14-qnrp9-worker-us-east-2c]
  I1014 10:59:31.642657 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machinesets.machine.openshift.io shudi-21a14-qnrp9-worker-us-east-2c -n openshift-machine-api -o=json'
  I1014 10:59:47.562241 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig create -f /tmp/e2e-test-cluster-infrastructure-upgrade-t45r4-machineset.json'
  machineset.machine.openshift.io/shudi-21a14-qnrp9-22612 created
  I1014 10:59:58.560379 5891 machine_helpers.go:236] Waiting for the machines Running ...
  I1014 11:00:58.562480 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machinesets.machine.openshift.io shudi-21a14-qnrp9-22612 -o=jsonpath={.status.readyReplicas} -n openshift-machine-api'
  I1014 11:01:14.588109 5891 machine_helpers.go:269] Expected 0  machines are Running
  I1014 11:01:14.588273 5891 machine_helpers.go:286] All machines are Running ...
  I1014 11:01:14.588341 5891 machine_helpers.go:222] Scaling MachineSets ...
  I1014 11:01:14.588806 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig scale --replicas=1 machinesets.machine.openshift.io shudi-21a14-qnrp9-22612 -n openshift-machine-api'
  I1014 11:01:20.589145 5891 machine_helpers.go:236] Waiting for the machines Running ...
  I1014 11:05:20.591586 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machinesets.machine.openshift.io shudi-21a14-qnrp9-22612 -o=jsonpath={.status.readyReplicas} -n openshift-machine-api'
  I1014 11:05:33.570283 5891 machine_helpers.go:269] Expected 1  machines are Running
  I1014 11:05:33.570429 5891 machine_helpers.go:286] All machines are Running ...
  I1014 11:05:33.570467 5891 machine_helpers.go:213] Getting MachineSets replicas ...
  I1014 11:05:33.570867 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machinesets.machine.openshift.io shudi-21a14-qnrp9-22612 -o=jsonpath={.spec.replicas} -n openshift-machine-api'
  I1014 11:05:39.290445 5891 machine_helpers.go:297] Wait nodes ready then check nodes haven't uninitialized taints...
  I1014 11:05:44.291527 5891 machine_helpers.go:144] Getting all Nodes in a Machineset ...
  I1014 11:05:44.292221 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machines.machine.openshift.io -o=jsonpath={.items[*].status.nodeRef.name} -l machine.openshift.io/cluster-api-machineset=shudi-21a14-qnrp9-22612 -n openshift-machine-api'
  I1014 11:06:00.045657 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get node ip-10-0-86-153.us-east-2.compute.internal -o=jsonpath={.status.conditions[?(@.type=="Ready")].status}'
  I1014 11:06:01.238001 5891 machine_helpers.go:308] node ip-10-0-86-153.us-east-2.compute.internal readyStatus: True
  I1014 11:06:01.238477 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get node ip-10-0-86-153.us-east-2.compute.internal -o=jsonpath={.spec.taints}'
  I1014 11:06:02.442188 5891 machine_helpers.go:320] All nodes are ready and haven't uninitialized taints ...
  I1014 11:06:02.442265 5891 machine_helpers.go:222] Scaling MachineSets ...
  I1014 11:06:02.442610 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig scale --replicas=0 machinesets.machine.openshift.io shudi-21a14-qnrp9-22612 -n openshift-machine-api'
  I1014 11:06:18.555046 5891 machine_helpers.go:236] Waiting for the machines Running ...
  I1014 11:07:18.556884 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machinesets.machine.openshift.io shudi-21a14-qnrp9-22612 -o=jsonpath={.status.readyReplicas} -n openshift-machine-api'
  I1014 11:07:24.396526 5891 machine_helpers.go:269] Expected 0  machines are Running
  I1014 11:07:24.396693 5891 machine_helpers.go:286] All machines are Running ...
  I1014 11:07:24.396718 5891 machine_helpers.go:64] Deleting a MachineSets ...
  I1014 11:07:24.397218 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig delete machinesets.machine.openshift.io shudi-21a14-qnrp9-22612 -n openshift-machine-api'
  machineset.machine.openshift.io "shudi-21a14-qnrp9-22612" deleted
  I1014 11:07:40.414423 5891 machine_helpers.go:366] Waiting for the machines Dissapper ...
  I1014 11:08:40.415983 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machines.machine.openshift.io -o=jsonpath={.items[*].metadata.name} -l machine.openshift.io/cluster-api-machineset=shudi-21a14-qnrp9-22612 -n openshift-machine-api'
  I1014 11:08:46.207906 5891 machine_helpers.go:373] All machines are Disappered
  I1014 11:08:57.106989 5891 client.go:676] Deleted {user.openshift.io/v1, Resource=users  e2e-test-cluster-infrastructure-upgrade-t45r4-user}, err: <nil>
  I1014 11:08:57.391984 5891 client.go:676] Deleted {oauth.openshift.io/v1, Resource=oauthclients  e2e-client-e2e-test-cluster-infrastructure-upgrade-t45r4}, err: <nil>
  I1014 11:08:57.673122 5891 client.go:676] Deleted {oauth.openshift.io/v1, Resource=oauthaccesstokens  sha256~4MV7bnG345Xtf_FbkYmDobBt0iDzqDbkWOFUtDb8QJE}, err: <nil>
  • SUCCESS! 10m55.10914456s 
passed: (11m13s) 2025-10-14T03:08:57 "[sig-cluster-lifecycle] Cluster_Infrastructure Upgrade Author:zhsun-NonHyperShiftHOST-NonPreRelease-PstChkUpgrade-LEVEL0-Critical-22612-Cluster could scale up/down after upgrade [Disruptive] [Serial][Slow]"

1 pass, 0 skip (11m13s)

rioliu-rh · 2025-10-14T04:33:43Z

/lgtm

openshift-ci · 2025-10-14T04:34:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huali9, rioliu-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/extended/util/compat_otp/OWNERS~~ [rioliu-rh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rioliu-rh · 2025-10-14T05:07:32Z

/test e2e-metal-ipi-ovn-ipv6

rioliu-rh · 2025-10-14T06:16:47Z

/retitle NO-JIRA: enhance-waitnodeready-util

openshift-ci-robot · 2025-10-14T06:16:56Z

@huali9: This pull request explicitly references no jira issue.

Details

In response to this:

Add https://github.com/openshift/openshift-tests-private/pull/26443 also to origin repo. It's for improving WaitForNodesReady func.
I have tested in my local and it works. @rioliu-rh PTAL, thanks!

liuhuali@Lius-MacBook-Pro openshift-tests-private % ./bin/extended-platform-tests run all --dry-run --timeout 60m |grep 22612 |./bin/extended-platform-tests run -f -
 I1014 10:57:41.720836 5884 test.go:180] Found authentication type used: 
 I1014 10:57:41.721151 5884 test_context.go:566] The --provider flag is not set. Continuing as if --provider=skeleton had been used.
 I1014 10:57:43.600010 5884 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get node -l node-role.kubernetes.io/worker -o=jsonpath={.items[*].metadata.name}'
 I1014 10:57:45.476351 5884 api.go:57] EnvIsKubernetesCluster = no, start monitoring ClusterOperators and ClusterVersions
started: (0/1/1) "[sig-cluster-lifecycle] Cluster_Infrastructure Upgrade Author:zhsun-NonHyperShiftHOST-NonPreRelease-PstChkUpgrade-LEVEL0-Critical-22612-Cluster could scale up/down after upgrade [Disruptive] [Serial][Slow]"

 I1014 10:58:00.523685 5891 openshift-tests.go:203] Is kubernetes cluster: no, is external OIDC cluster: no
 I1014 10:58:00.524060 5891 test_context.go:566] The --provider flag is not set. Continuing as if --provider=skeleton had been used.
 I1014 10:58:01.013788 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get node -l node-role.kubernetes.io/worker -o=jsonpath={.items[*].metadata.name}'
 [1760410665] openshift extended e2e - 1/1 specs I1014 10:58:07.528691 5891 client.go:288] configPath is now "/var/folders/yc/y9zy01jn3f51r9knbpsm_55r0000gn/T/configfile2219945927"
 I1014 10:58:07.528754 5891 client.go:363] The user is now "e2e-test-cluster-infrastructure-upgrade-t45r4-user"
 I1014 10:58:07.528766 5891 client.go:365] Creating project "e2e-test-cluster-infrastructure-upgrade-t45r4"
 I1014 10:58:08.884197 5891 client.go:373] Waiting on permissions in project "e2e-test-cluster-infrastructure-upgrade-t45r4" ...
 I1014 10:58:09.981365 5891 client.go:402] DeploymentConfig capability is enabled, adding 'deployer' SA to the list of default SAs
 I1014 10:58:10.254615 5891 client.go:417] Waiting for ServiceAccount "default" to be provisioned...
 I1014 10:58:10.898909 5891 client.go:417] Waiting for ServiceAccount "builder" to be provisioned...
 I1014 10:58:11.543415 5891 client.go:417] Waiting for ServiceAccount "deployer" to be provisioned...
 I1014 10:58:12.191637 5891 client.go:427] Waiting for RoleBinding "system:image-pullers" to be provisioned...
 I1014 10:58:12.732472 5891 client.go:427] Waiting for RoleBinding "system:image-builders" to be provisioned...
 I1014 10:58:13.269252 5891 client.go:427] Waiting for RoleBinding "system:deployers" to be provisioned...
 I1014 10:58:14.331297 5891 client.go:460] Project "e2e-test-cluster-infrastructure-upgrade-t45r4" has been fully provisioned.
 I1014 10:58:14.331982 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get node -l node-role.kubernetes.io/master -o jsonpath='{.items[*].metadata.name}''
 I1014 10:58:15.901391 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get node -l node-role.kubernetes.io/worker -o jsonpath='{.items[*].metadata.name}''
 I1014 10:58:27.367532 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get infrastructure cluster -o=jsonpath={.status.platformStatus.type}'
 I1014 10:58:28.297175 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machines.machine.openshift.io --no-headers -n openshift-machine-api'
 I1014 10:58:34.089408 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get infrastructure cluster -o=jsonpath={.status.platformStatus.type}'
 I1014 10:58:45.008387 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get infrastructure cluster -o=jsonpath={.status.infrastructureName}'
 I1014 10:58:46.039663 5891 machine_helpers.go:39] Creating a new MachineSets ...
 I1014 10:58:46.039885 5891 machine_helpers.go:188] Getting a random MachineSet ...
 I1014 10:58:46.040542 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get infrastructure cluster -o=jsonpath={.status.platformStatus.type}'
 I1014 10:58:56.982362 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get nodes -l node-role.kubernetes.io/worker --show-labels'
 I1014 10:58:58.369809 5891 machine_helpers.go:78] Listing all MachineSets ...
 I1014 10:58:58.370390 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machinesets.machine.openshift.io -o=jsonpath={.items[*].metadata.name} -n openshift-machine-api'
 I1014 10:59:04.406372 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machinesets.machine.openshift.io shudi-21a14-qnrp9-worker-us-east-2a -o=jsonpath={.spec.template.metadata.labels} -n openshift-machine-api'
 I1014 10:59:20.424822 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machinesets.machine.openshift.io shudi-21a14-qnrp9-worker-us-east-2b -o=jsonpath={.spec.template.metadata.labels} -n openshift-machine-api'
 I1014 10:59:26.077168 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machinesets.machine.openshift.io shudi-21a14-qnrp9-worker-us-east-2c -o=jsonpath={.spec.template.metadata.labels} -n openshift-machine-api'
 I1014 10:59:31.642222 5891 machine_helpers.go:93] linuxWorkerMachineSetNames: [shudi-21a14-qnrp9-worker-us-east-2a shudi-21a14-qnrp9-worker-us-east-2b shudi-21a14-qnrp9-worker-us-east-2c]
 I1014 10:59:31.642657 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machinesets.machine.openshift.io shudi-21a14-qnrp9-worker-us-east-2c -n openshift-machine-api -o=json'
 I1014 10:59:47.562241 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig create -f /tmp/e2e-test-cluster-infrastructure-upgrade-t45r4-machineset.json'
 machineset.machine.openshift.io/shudi-21a14-qnrp9-22612 created
 I1014 10:59:58.560379 5891 machine_helpers.go:236] Waiting for the machines Running ...
 I1014 11:00:58.562480 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machinesets.machine.openshift.io shudi-21a14-qnrp9-22612 -o=jsonpath={.status.readyReplicas} -n openshift-machine-api'
 I1014 11:01:14.588109 5891 machine_helpers.go:269] Expected 0  machines are Running
 I1014 11:01:14.588273 5891 machine_helpers.go:286] All machines are Running ...
 I1014 11:01:14.588341 5891 machine_helpers.go:222] Scaling MachineSets ...
 I1014 11:01:14.588806 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig scale --replicas=1 machinesets.machine.openshift.io shudi-21a14-qnrp9-22612 -n openshift-machine-api'
 I1014 11:01:20.589145 5891 machine_helpers.go:236] Waiting for the machines Running ...
 I1014 11:05:20.591586 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machinesets.machine.openshift.io shudi-21a14-qnrp9-22612 -o=jsonpath={.status.readyReplicas} -n openshift-machine-api'
 I1014 11:05:33.570283 5891 machine_helpers.go:269] Expected 1  machines are Running
 I1014 11:05:33.570429 5891 machine_helpers.go:286] All machines are Running ...
 I1014 11:05:33.570467 5891 machine_helpers.go:213] Getting MachineSets replicas ...
 I1014 11:05:33.570867 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machinesets.machine.openshift.io shudi-21a14-qnrp9-22612 -o=jsonpath={.spec.replicas} -n openshift-machine-api'
 I1014 11:05:39.290445 5891 machine_helpers.go:297] Wait nodes ready then check nodes haven't uninitialized taints...
 I1014 11:05:44.291527 5891 machine_helpers.go:144] Getting all Nodes in a Machineset ...
 I1014 11:05:44.292221 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machines.machine.openshift.io -o=jsonpath={.items[*].status.nodeRef.name} -l machine.openshift.io/cluster-api-machineset=shudi-21a14-qnrp9-22612 -n openshift-machine-api'
 I1014 11:06:00.045657 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get node ip-10-0-86-153.us-east-2.compute.internal -o=jsonpath={.status.conditions[?(@.type=="Ready")].status}'
 I1014 11:06:01.238001 5891 machine_helpers.go:308] node ip-10-0-86-153.us-east-2.compute.internal readyStatus: True
 I1014 11:06:01.238477 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get node ip-10-0-86-153.us-east-2.compute.internal -o=jsonpath={.spec.taints}'
 I1014 11:06:02.442188 5891 machine_helpers.go:320] All nodes are ready and haven't uninitialized taints ...
 I1014 11:06:02.442265 5891 machine_helpers.go:222] Scaling MachineSets ...
 I1014 11:06:02.442610 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig scale --replicas=0 machinesets.machine.openshift.io shudi-21a14-qnrp9-22612 -n openshift-machine-api'
 I1014 11:06:18.555046 5891 machine_helpers.go:236] Waiting for the machines Running ...
 I1014 11:07:18.556884 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machinesets.machine.openshift.io shudi-21a14-qnrp9-22612 -o=jsonpath={.status.readyReplicas} -n openshift-machine-api'
 I1014 11:07:24.396526 5891 machine_helpers.go:269] Expected 0  machines are Running
 I1014 11:07:24.396693 5891 machine_helpers.go:286] All machines are Running ...
 I1014 11:07:24.396718 5891 machine_helpers.go:64] Deleting a MachineSets ...
 I1014 11:07:24.397218 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig delete machinesets.machine.openshift.io shudi-21a14-qnrp9-22612 -n openshift-machine-api'
 machineset.machine.openshift.io "shudi-21a14-qnrp9-22612" deleted
 I1014 11:07:40.414423 5891 machine_helpers.go:366] Waiting for the machines Dissapper ...
 I1014 11:08:40.415983 5891 client.go:1023] Running 'oc --kubeconfig=/Users/liuhuali/huali-test/kubeconfig get machines.machine.openshift.io -o=jsonpath={.items[*].metadata.name} -l machine.openshift.io/cluster-api-machineset=shudi-21a14-qnrp9-22612 -n openshift-machine-api'
 I1014 11:08:46.207906 5891 machine_helpers.go:373] All machines are Disappered
 I1014 11:08:57.106989 5891 client.go:676] Deleted {user.openshift.io/v1, Resource=users  e2e-test-cluster-infrastructure-upgrade-t45r4-user}, err: <nil>
 I1014 11:08:57.391984 5891 client.go:676] Deleted {oauth.openshift.io/v1, Resource=oauthclients  e2e-client-e2e-test-cluster-infrastructure-upgrade-t45r4}, err: <nil>
 I1014 11:08:57.673122 5891 client.go:676] Deleted {oauth.openshift.io/v1, Resource=oauthaccesstokens  sha256~4MV7bnG345Xtf_FbkYmDobBt0iDzqDbkWOFUtDb8QJE}, err: <nil>
 • SUCCESS! 10m55.10914456s 
passed: (11m13s) 2025-10-14T03:08:57 "[sig-cluster-lifecycle] Cluster_Infrastructure Upgrade Author:zhsun-NonHyperShiftHOST-NonPreRelease-PstChkUpgrade-LEVEL0-Critical-22612-Cluster could scale up/down after upgrade [Disruptive] [Serial][Slow]"

1 pass, 0 skip (11m13s)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

huali9 · 2025-10-14T06:28:28Z

verified by @huali9
tested in my local and it works!

rioliu-rh · 2025-10-14T06:32:38Z

/verified by @huali9

openshift-ci-robot · 2025-10-14T06:32:50Z

@rioliu-rh: This PR has been marked as verified by @huali9.

Details

In response to this:

/verified by @huali9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rioliu-rh · 2025-10-14T06:33:42Z

/retest

openshift-ci-robot · 2025-10-14T07:37:15Z

/retest-required

Remaining retests: 0 against base HEAD 00af731 and 2 for PR HEAD b1887c5 in total

rioliu-rh · 2025-10-14T10:35:19Z

/test e2e-aws-ovn-serial-2of2

openshift-ci · 2025-10-14T14:01:53Z

@huali9: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

huali9 · 2025-12-23T01:44:01Z

/cherry-pick release-4.20

openshift-cherrypick-robot · 2025-12-23T01:44:50Z

@huali9: new pull request created: #30638

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

enhance-waitnodeready-util

b1887c5

openshift-ci bot requested review from ming1013 and tomasdavidorg October 14, 2025 04:13

openshift-ci bot assigned rioliu-rh Oct 14, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2025

openshift-ci bot changed the title ~~enhance-waitnodeready-util~~ NO-JIRA: enhance-waitnodeready-util Oct 14, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 14, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 14, 2025

openshift-merge-bot bot merged commit 00a8b7b into openshift:main Oct 16, 2025
20 checks passed

openshift-cherrypick-robot mentioned this pull request Dec 23, 2025

[release-4.20] NO-JIRA: enhance-waitnodeready-util #30638

Open

NO-JIRA: enhance-waitnodeready-util #30377

NO-JIRA: enhance-waitnodeready-util #30377

Conversation

huali9 commented Oct 14, 2025

Uh oh!

rioliu-rh commented Oct 14, 2025

Uh oh!

openshift-ci bot commented Oct 14, 2025

Uh oh!

rioliu-rh commented Oct 14, 2025

Uh oh!

rioliu-rh commented Oct 14, 2025

Uh oh!

openshift-ci-robot commented Oct 14, 2025

Uh oh!

huali9 commented Oct 14, 2025

Uh oh!

rioliu-rh commented Oct 14, 2025

Uh oh!

openshift-ci-robot commented Oct 14, 2025

Uh oh!

rioliu-rh commented Oct 14, 2025

Uh oh!

openshift-ci-robot commented Oct 14, 2025

Uh oh!

rioliu-rh commented Oct 14, 2025

Uh oh!

openshift-ci bot commented Oct 14, 2025

Uh oh!

Uh oh!

huali9 commented Dec 23, 2025

Uh oh!

openshift-cherrypick-robot commented Dec 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants