[release-4.20] OCPBUGS-64836: back-port IP & MAC conflict detection e2e tests #30414
Conversation
Validates that KubeVirt VMs with preconfigured MAC and IP addresses maintain those addresses correctly before and after a vmi with duplicate IP/MAC request is made, and that the vmi with the duplicate address get the appropriate address conflict error event. Co-authored-by: Miguel Duarte Barroso <mdbarroso@redhat.com> Signed-off-by: Ram Lavi <ralavi@redhat.com> (cherry picked from commit 6dd2a93)
The requested IPs for the primary UDN attachment are not in the VMI spec, but in an annotation in the VMI. Hence, we need to fetch that particular annotation, and set it in the duplicate VMI. This was implemented using the builder pattern, since I suspect in the future we will need to further customize the VMI spec / metadata; this will make it simpler to extend the framework in the future. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com> (cherry picked from commit 13fdf10)
This way we can ensure appropriate cases are caught in a generic way. With it, we can safely expect to find IP conflicts when there are duplicate IPs in the network. In future commits, we will be able to catch MAC conflicts when there are duplicate MACs in the network Co-authored-by: Ram Lavi <ralavi@redhat.com> Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com> (cherry picked from commit fdb0584)
openshift-ci-robot
added
the
jira/valid-reference
|
@ormergi: This pull request references CORENET-6378 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/ovn-kubernetes#2827 #30415 |
|
@ormergi, |
|
/testwith openshift/origin/main/periodic-ci-openshift-ovn-kubernetes-release-4.20-periodics-e2e-metal-ipi-ovn-bgp-virt-dualstack openshift/ovn-kubernetes#2827 #30415 |
|
@ormergi, |
|
/testwith openshift/origin/release-4.20/e2e-metal-ipi-ovn-bgp-virt-dualstack openshift/ovn-kubernetes#2827 #30415 |
|
Testing this PR with the incoming IP & MAC conflict bits and the [missing fix in tests] (#30415) on on 4.20 is green |
|
/retest-required |
|
/retitle [release-4.20] OCPBUGS-64836: back-port IP & MAC conflict detection e2e tests |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-bug
|
@ormergi: This pull request references Jira Issue OCPBUGS-64836, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/tide refresh |
|
/testwith openshift/origin/release-4.20/e2e-metal-ipi-ovn-bgp-virt-ipv4 openshift/ovn-kubernetes#2827 /testwith openshift/origin/release-4.20/e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview openshift/ovn-kubernetes#2827 |
|
@ormergi, |
|
@ormergi, |
|
/testwith openshift/origin/main/periodic-ci-openshift-ovn-kubernetes-release-4.20-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4 openshift/ovn-kubernetes#2827 /testwith openshift/origin/main/periodic-ci-openshift-ovn-kubernetes-release-4.20-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview openshift/ovn-kubernetes#2827 |
|
@ormergi, |
|
@ormergi, |
|
/testwith openshift/origin/release-4.20/e2e-metal-ipi-ovn-bgp-virt-dualstack openshift/ovn-kubernetes#2827 #30415 |
|
@kyrtapz: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/30143170-cea9-11f0-8e15-d791a3d4c5de-0 |
|
@kyrtapz: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7acce030-cecd-11f0-9576-b3bf9e4e76e0-0 |
Verify KubeVirt VMs with preconfigured MAC address retain a requested MAC address before and after another VM is created requesting the same MAC address. And verify the other VM requesting the same MAC address get the appropriate address conflict error event. Signed-off-by: Or Mergi <ormergi@redhat.com> (cherry picked from commit 0c58f2a)
ormergi
force-pushed
the
bp-ip-mac-conflict-detection-e2e
branch
from
49ac8bc to
d21f207
Compare
|
verify job is green, lets see how payloads acts /payload-job-with-prs periodic-ci-openshift-ovn-kubernetes-release-4.20-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4 openshift/api#2546 |
|
/payload-job periodic-ci-openshift-ovn-kubernetes-release-4.20-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview |
|
@ormergi: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8afd2ba0-cf7b-11f0-8c45-0ce31a7b30da-0 |
|
/retest-required |
|
/lgtm |
|
/payload-job periodic-ci-openshift-ovn-kubernetes-release-4.20-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview |
|
@ormergi: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f4dc71d0-d344-11f0-943e-e0e6c7c62142-0 |
|
/verified |
|
@ormergi: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified later |
|
@ormergi: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified later @ormergi |
openshift-ci-robot
added
verified-later
verified
|
@ormergi: This PR has been marked to be verified later by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyrtapz, maiqueb, neisw, ormergi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@ormergi: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
6 participants
This is manual check-pick of IP conflict detection tests [1] (commits 1-3) and MAC conflict detection tests [2] (commit 4).
Commits were cherry-picked from release-4.21 branch.
[1] #30197
[2] #30314