Skip to content

TRT-2386: Revert #30296 "OTA-1637: ClusterOperators should not go Progressing only for a node reboot" #30437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Oct 29, 2025
Merged

TRT-2386: Revert #30296 "OTA-1637: ClusterOperators should not go Progressing only for a node reboot" #30437

openshift-merge-bot merged 1 commit into from
Oct 29, 2025

Conversation

@xueqzhan
Copy link
Contributor

@xueqzhan xueqzhan commented Oct 29, 2025 •
edited by openshift-ci bot
Loading

Reverts #30296 ; tracked by TRT-2386

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This failed the latest 4.21 nightly. Please make sure to run suggested commands and see no CO failing the test

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload 4.21 nightly blocking

CC: @hongkailiu

PR created by Revertomatic™️

@xueqzhan
Revert "Merge pull request openshift#30296 from hongkailiu/OTA-1637-r…
7657bcc 
…eboot"

This reverts commit e603cd9, reversing
changes made to b60bbfe.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 29, 2025 •
edited by openshift-ci bot
Loading

@xueqzhan: This pull request references TRT-2386 which is a valid jira issue.

Details

In response to this:

Reverts #30296 ; tracked by TRT-2386

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This failed the latest 4.21 nightly. Please make sure to run suggested commands and see no CO failing the test

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload 4.21 nightly blocking

CC: @hongkailiu

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from p0lyn0mial and sjenning October 29, 2025 13:02
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2025
@hongkailiu
Copy link
Member

hongkailiu commented Oct 29, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xueqzhan
Copy link
Contributor Author

xueqzhan commented Oct 29, 2025

/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-aws-ovn-serial-2of2
/override ci/prow/e2e-aws-ovn-serial-1of2
/override ci/prow/e2e-aws-ovn-microshift-serial
/override ci/prow/e2e-vsphere-ovn-upi
/override ci/prow/e2e-aws-ovn-microshift
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-vsphere-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

@xueqzhan: Overrode contexts on behalf of xueqzhan: ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-microshift, ci/prow/e2e-aws-ovn-microshift-serial, ci/prow/e2e-aws-ovn-serial-1of2, ci/prow/e2e-aws-ovn-serial-2of2, ci/prow/e2e-gcp-csi, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-vsphere-ovn, ci/prow/e2e-vsphere-ovn-upi

Details

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-aws-ovn-serial-2of2
/override ci/prow/e2e-aws-ovn-serial-1of2
/override ci/prow/e2e-aws-ovn-microshift-serial
/override ci/prow/e2e-vsphere-ovn-upi
/override ci/prow/e2e-aws-ovn-microshift
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-vsphere-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hongkailiu hongkailiu mentioned this pull request Oct 29, 2025
Merged
@hongkailiu
Copy link
Member

hongkailiu commented Oct 29, 2025

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 29, 2025

@hongkailiu: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xueqzhan
Copy link
Contributor Author

xueqzhan commented Oct 29, 2025

/verified bypass

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 29, 2025

@xueqzhan:

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit a91d3d0 into openshift:main Oct 29, 2025
20 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

@xueqzhan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@hongkailiu hongkailiu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xueqzhan @openshift-ci-robot @hongkailiu