Skip to content

OCPBUGS-66419: fix: handing static pods not appearing on SNO+RT metal lanes #30608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeff-roche wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-66419: fix: handing static pods not appearing on SNO+RT metal lanes #30608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pkg/monitortests/kubeapiserver/legacykubeapiservermonitortests/static_pod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,11 @@ func testStaticPodLifecycleFailure(events monitorapi.Intervals, kubeClientConfig
matches := regexp.MustCompile("to ([0-9]+) because static pod is ready").FindStringSubmatch(event.Note)
if len(matches) == 2 {
reachedRevision, _ := strconv.ParseInt(matches[1], 0, 64)
if isRevisionUpdate && isForNode && reachedRevision == staticPodFailure.revision {
if isRevisionUpdate && isForNode && reachedRevision >= staticPodFailure.revision {
// If we reach the level eventually, don't fail the test. We might choose to add an "it's slow" test, but
// it hasn't failed. It might be possible to go directly to a later revision, and if we want to account for
// that, the above could be changed to >= instead of equality.
// it hasn't failed. It is possible to go directly to a later revision such as in a RT environment where
// revisions can happen rapidly. In this case, it is okay if a revision never appears and a later revision
// is located.
foundEventForProperRevision = true
}
}
Expand Down