Skip to content

OCPBUGS-69400: Ignore repeated TopologyAwareHintsDisabled events #30614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Miciah wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −0
Open

OCPBUGS-69400: Ignore repeated TopologyAwareHintsDisabled events #30614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,22 @@ func NewUniversalPathologicalEventMatchers(kubeConfig *rest.Config, finalInterva
neverAllow: true,
})

// Ignore repeated TopologyAwareHintsDisabled events from the endpoint
// slice controller's topology cache. The controller emits these events
// if a service (such as the cluster DNS service) enables topology-aware
// hints but certain "safeguards" (such as having sufficient service
// endpoints and sufficient nodes with allocatable CPU in each zone) are
// not met, in which case the default non-topology-aware behavior is
// used. This means that the service remains reachable even if these
// events are emitted. Note also that ovn-kubernetes does not implement
// topology-aware hints; the feature is enabled only for the benefit of
// third-party CNI plugins, such as Calico.
registry.AddPathologicalEventMatcherOrDie(&SimplePathologicalEventMatcher{
name: "TopologyAwareHintsDisabled",
messageReasonRegex: regexp.MustCompile(`^TopologyAwareHintsDisabled$`),
jira: "https://issues.redhat.com/browse/OCPBUGS-69400",
})

registry.AddPathologicalEventMatcherOrDie(AllowBackOffRestartingFailedContainer)

registry.AddPathologicalEventMatcherOrDie(AllowOVNReadiness)
Expand Down