Skip to content

[release-4.21] OCPBUGS-70143: Fix race condition in external binary extraction #30641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
openshift-cherrypick-robot wants to merge 1 commit into
base: release-4.21
Choose a base branch
from
Open

[release-4.21] OCPBUGS-70143: Fix race condition in external binary extraction #30641

openshift-cherrypick-robot wants to merge 1 commit into from
+35 −3

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Dec 24, 2025

This is an automated cherry-pick of #30616

/assign openshift-ci-robot

@stbenjam
Fix race condition in external binary extraction
37b61e1 
When multiple openshift-tests processes run concurrently and share
the same cache directory, they can race on extracting and decompressing
the same binaries. This commonly occurs when using shell pipelines like:

  openshift-tests run ... --dry-run | openshift-tests run -f -

Both processes start simultaneously, and without synchronization, one
process may delete a .gz file while another is still trying to access it,
resulting in errors like "failed to delete original .gz file: no such
file or directory".

Add flock-based file locking around the extraction process to ensure
only one process extracts a given binary at a time. The lock is
automatically released when the process exits, even if killed.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 24, 2025
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 24, 2025

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-67313 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.21] OCPBUGS-70143: Fix race condition in external binary extraction

Details

In response to this:

This is an automated cherry-pick of #30616

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.21] OCPBUGS-67313: Fix race condition in external binary extraction [release-4.21] OCPBUGS-70143: Fix race condition in external binary extraction Dec 24, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 24, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-70143, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #30616

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and sjenning December 24, 2025 12:39
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 24, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-images 37b61e1 link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@openshift-ci-robot openshift-ci-robot

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openshift-cherrypick-robot @openshift-ci-robot @stbenjam