-
Notifications
You must be signed in to change notification settings - Fork 4.8k
[release-4.20] OCPBUGS-70144: Fix race condition in external binary extraction #30642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.20
Are you sure you want to change the base?
Conversation
When multiple openshift-tests processes run concurrently and share the same cache directory, they can race on extracting and decompressing the same binaries. This commonly occurs when using shell pipelines like: openshift-tests run ... --dry-run | openshift-tests run -f - Both processes start simultaneously, and without synchronization, one process may delete a .gz file while another is still trying to access it, resulting in errors like "failed to delete original .gz file: no such file or directory". Add flock-based file locking around the extraction process to ensure only one process extracts a given binary at a time. The lock is automatically released when the process exits, even if killed.
|
@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-67313 with correct target version. Will retitle the PR to link to the clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-70144, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #30616
/assign openshift-ci-robot