CORENET-6864, CORENET-6169: remove some duplicate ovnk test cases#30820
CORENET-6864, CORENET-6169: remove some duplicate ovnk test cases#30820openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
the following test cases are duplicated with test that will run with the ovnk OTE work which will be enabled with this PR [0]. they are failing because upstream OVNK has bumped it's CNI version to 1.1.0 and these tests are hardcoded here (or in multus [1]) and don't accept 1.1.0 yet. The upstream change in ovnk also updated it's tests so when they run via OTE, they will pass. [0] openshift#30560 [1] openshift/multus-cni#278 Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@jluhrsen: This pull request references CORENET-6864 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. This pull request references CORENET-6169 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting 📒 Files selected for processing (1)
WalkthroughThe pull request removes test coverage from a networking test file by eliminating two test cases and associated helper functions that validated NetworkAttachmentDefinition manifest generation, while adjusting imports. The functional test surface is reduced without any API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.5.0)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions Comment |
|
@jluhrsen: This pull request references CORENET-6864 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. This pull request references CORENET-6169 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling required tests: |
|
/test e2e-aws-ovn-fips |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, jluhrsen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@jluhrsen: This PR was included in a payload test run from #30560
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4a0c25c0-1679-11f1-8a25-13b12bdf4648-0 |
|
@jluhrsen: This PR was included in a payload test run from #30560
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/957eef30-16bd-11f1-8ef6-8f3a336991c0-0 |
|
@jluhrsen: This PR was included in a payload test run from #30560
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/03ce5310-174d-11f1-8109-f196366c640e-0 |
openshift-ci-robot
added
the
verified
|
@jluhrsen: This PR has been marked as verified by DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test images |
|
Scheduling required tests: |
|
/test e2e-aws-ovn-serial-1of2 |
|
@jluhrsen: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
the following test cases are duplicated with test that will run with the ovnk OTE work which will be enabled with this PR [0]. they are failing because upstream OVNK has bumped it's CNI version to 1.1.0 and these tests are hardcoded here (or in multus [1]) and don't accept 1.1.0 yet. The upstream change in ovnk also updated it's tests so when they run via OTE, they will pass.
[0] #30560
[1] openshift/multus-cni#278
Summary by CodeRabbit