Skip to content

[release-4.17] OCPBUGS-60896: Revert "40rhcos-fips: include fips.so in initrd" #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Aug 28, 2025
Merged

[release-4.17] OCPBUGS-60896: Revert "40rhcos-fips: include fips.so in initrd" #1859

openshift-merge-bot merged 1 commit into from
Aug 28, 2025

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Aug 26, 2025

This is an automated cherry-pick of #1855

/assign openshift-ci-robot

@mike-nguyen
Revert "40rhcos-fips: include fips.so in initrd"
73e1b8d 
This reverts commit f21c511.

This was fixed upstream in in RHEL so this patch is no longer
needed.

9.4 - https://issues.redhat.com/browse/RHEL-104864
9.2 - https://issues.redhat.com/browse/RHEL-104863
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 26, 2025
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 26, 2025

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-60201 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.17] OCPBUGS-60896: Revert "40rhcos-fips: include fips.so in initrd"

Details

In response to this:

This is an automated cherry-pick of #1855

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.17] OCPBUGS-60201: Revert "40rhcos-fips: include fips.so in initrd" [release-4.17] OCPBUGS-60896: Revert "40rhcos-fips: include fips.so in initrd" Aug 26, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 26, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 26, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-60896, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-60201 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-60201 targets the "4.18.z" version, which is one of the valid target versions: 4.18.0, 4.18.z
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1855

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

marmijo
marmijo approved these changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marmijo, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2025
@mike-nguyen
Copy link
Member

mike-nguyen commented Aug 27, 2025

/retest

@mike-nguyen
Copy link
Member

mike-nguyen commented Aug 27, 2025

/test all

@mike-nguyen
Copy link
Member

mike-nguyen commented Aug 27, 2025

coreos/coreos-assembler#4264 merged so re-running CI tests to ensure the test passes with this fix.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 27, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mike-nguyen
Copy link
Member

mike-nguyen commented Aug 28, 2025

/label backport-risk-assessed
/label cherry-pick-approved

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Aug 28, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 894f839 into openshift:release-4.17 Aug 28, 2025
5 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 28, 2025

@openshift-cherrypick-robot: Jira Issue OCPBUGS-60896: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-60896 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #1855

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mike-nguyen mike-nguyen Awaiting requested review from mike-nguyen

@travier travier Awaiting requested review from travier

@yasminvalim yasminvalim Awaiting requested review from yasminvalim

1 more reviewer

@marmijo marmijo marmijo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@openshift-ci-robot openshift-ci-robot

@marmijo marmijo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @openshift-ci-robot @mike-nguyen @marmijo