Add deferred Orion summary report step for consolidated regression reporting #75575
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -408,6 +408,7 @@ tests: | |
| COMPUTE_NODE_REPLICAS: "24" | ||
| COMPUTE_NODE_TYPE: m5.xlarge | ||
| EXTRA_MG_ARGS: --host-network | ||
| RUN_ORION: deferred | ||
| UDN_ITERATION_MULTIPLIER: "3" | ||
| VERSION: "4.18" | ||
| post: | ||
|
|
@@ -428,6 +429,7 @@ tests: | |
| ENABLE_LAYER_3: "false" | ||
| EXTRA_MG_ARGS: --host-network | ||
| KUBE_BURNER_VERSION: 1.5.0 | ||
| RUN_ORION: deferred | ||
| UDN_ITERATION_MULTIPLIER: "3" | ||
|
Member
There was a problem hiding this comment. Are you adding on purpose orion to more jobs? i.e.: here it's qe-perfscale-aws-ovn-small-udn-density-l2
Member
Author
There was a problem hiding this comment. so currently we have udn-density chain |
||
| post: | ||
| - chain: ipi-aws-post | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| approvers: | ||
| - perfscale-ocp-approvers | ||
| reviewers: | ||
| - perfscale-ocp-reviewers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| #!/bin/bash | ||
| set -x | ||
| set -euo pipefail | ||
|
|
||
| if [ "${RUN_ORION}" == "false" ]; then | ||
| echo "RUN_ORION is false, skipping report." | ||
| exit 0 | ||
| fi | ||
|
|
||
| # Check for deferred JSON results | ||
| shopt -s nullglob | ||
| json_files=("${SHARED_DIR}"/orion-*.json) | ||
| shopt -u nullglob | ||
|
|
||
| if [ ${#json_files[@]} -eq 0 ]; then | ||
| echo "No deferred orion JSON results found in SHARED_DIR." | ||
| echo "This is expected when RUN_ORION is not set to deferred." | ||
| exit 0 | ||
| fi | ||
|
|
||
| # Copy JSONs to ARTIFACT_DIR for archival | ||
| cp "${json_files[@]}" "${ARTIFACT_DIR}/" 2>/dev/null || true | ||
|
|
||
| # Set up Python environment and install orion | ||
| python --version | ||
| pushd /tmp | ||
| python -m virtualenv ./venv_report | ||
| source ./venv_report/bin/activate | ||
|
|
||
| ## TODO: revert before merge - using fork for testing | ||
| git clone --branch summary-analysis https://github.com/mohit-sheth/orion.git --depth 1 | ||
| pushd orion | ||
| pip install -r requirements.txt | ||
| pip install . | ||
| popd && popd | ||
|
|
||
| # Build comma-separated file list for orion --report | ||
| json_file_list="" | ||
| for f in "${json_files[@]}"; do | ||
| json_file_list="${json_file_list:+${json_file_list},}${f}" | ||
| done | ||
|
|
||
| # Run orion report on all deferred JSONs | ||
| # orion --report exits 2 if regressions found, 0 otherwise | ||
| set +e | ||
| orion --report "$json_file_list" | ||
| report_exit=$? | ||
| set -e | ||
|
|
||
| if [ "$report_exit" -eq 2 ]; then | ||
| echo "Orion report detected regressions." | ||
| exit 1 | ||
| fi | ||
|
|
||
| exit "$report_exit" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "path": "openshift-qe/orion/report/openshift-qe-orion-report-ref.yaml", | ||
| "owners": { | ||
| "approvers": [ | ||
| "perfscale-ocp-approvers" | ||
| ], | ||
| "reviewers": [ | ||
| "perfscale-ocp-reviewers" | ||
| ] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| ref: | ||
| as: openshift-qe-orion-report | ||
| from_image: | ||
| namespace: ci | ||
| name: ocp-qe-perfscale-ci | ||
| tag: latest | ||
| env: | ||
| - name: ORION_REPO | ||
| default: "https://github.com/cloud-bulldozer/orion.git" | ||
| documentation: | ||
| Orion github repository to clone for report generation. | ||
| - name: TAG | ||
| default: "latest" | ||
| documentation: | ||
| Orion version/tag to clone. | ||
| - name: RUN_ORION | ||
| default: "false" | ||
| documentation: | ||
| When false, the report step is skipped. Set to deferred at test level to enable deferred failure reporting. | ||
| commands: openshift-qe-orion-report-commands.sh | ||
| timeout: 30m | ||
| resources: | ||
| requests: | ||
| cpu: 100m | ||
| memory: 100Mi | ||
| documentation: >- | ||
| Aggregates deferred orion regression results from SHARED_DIR using | ||
| orion --report to produce a consolidated regression report. Must be | ||
| used as the last step in an orion chain when RUN_ORION is set to deferred. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed in Slack this is strange, the fact that
"true"was quoted anddeferredis not ..There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make update changes this