MCO-1968: Move cloud disruptive test variants to standard jobTier in sippy

[djoshy]

This sets all of MCO's non metal 4.21 & 4.22 disruptive jobs to the standard tier, permitting them report to MCO's CR. All 4.19/4.20 jobs and metal jobs have been excluded.

Summary by CodeRabbit

• Chores
  • Refined job tier classifications for Machine Config Operator-related tests with granular control by specific platform variants and software releases.
  • Updated default handling for MCO-related jobs to improve resource allocation.
  • Expanded test configuration entries for specific platform types and upgrade paths in CI infrastructure.

[openshift-ci-robot]

Pipeline controller notification
This repository is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. Review these jobs and use /test <job> to manually trigger optional jobs most likely to be impacted by the proposed changes.

[openshift-ci-robot]

@djoshy: This pull request references MCO-1968 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This sets all of MCO's non metal disruptive jobs to the standard tier, permitting them report to MCO's CR. All 4.19/4.20 jobs and metal jobs have been excluded.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

This PR refactors machine configuration operator (MCO) job tier assignments in the variant registry. It replaces a historical MCO-related candidate entry with granular metal-specific and release-specific MCO variants, introduces new AWS OVN OCL standard entries, and adjusts default MCO job tier handling from candidate to standard.

Changes

Cohort / File(s)	Summary
MCO Job Tier Refactoring pkg/variantregistry/ocp.go	Replaces single {-mco-disruptive} candidate mapping with: three metal-specific MCO disruptive entries (candidate tier), two AWS OVN OCL entries (standard tier), two release-specific MCO entries for 4.19/4.20 (candidate tier), and updates default MCO disruptive handling to standard tier.
JobTier Value Updates pkg/variantregistry/snapshot.yaml	Updates JobTier field from candidate to standard across multiple periodic CI entries. Bulk configuration change with no structural alterations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

• Verify MCO job tier logic changes produce expected categorization across all variants
• Confirm snapshot.yaml updates align with ocp.go registry changes and reflect intended CI job prioritization
• Ensure no existing functionality is inadvertently affected by the tier reassignments

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Single Responsibility And Clear Naming	⚠️ Warning	OCPRegistry struct contains duplicate sync.RWMutex fields (mu and lock), violating Single Responsibility by maintaining multiple redundant synchronization primitives instead of one clear locking mechanism.	Remove duplicate lock fields and keep only one descriptive RWMutex (e.g., ruleMutex) to ensure single synchronization responsibility and consistent usage across all methods.

✅ Passed checks (6 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Go Error Handling	✅ Passed	PR contains YAML configuration updates without substantive Go error handling code changes, so no violations to assess.
Sql Injection Prevention	✅ Passed	Pull request modifies configuration files with job tier mappings and CI/CD variant registry data. No SQL query construction, database operations, or dynamic query building is present.
Excessive Css In React Should Use Styles	✅ Passed	PR modifies Go and YAML backend files, not React components with inline CSS.
Title check	✅ Passed	The title clearly references the specific Jira issue (MCO-1968) and accurately summarizes the main change: moving cloud disruptive test variants to standard jobTier in sippy.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[djoshy]

/hold

Throwing in a hold for the moment, need to get consensus from the MCO team 😄

[openshift-ci-robot]

@djoshy: This pull request references MCO-1968 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This sets all of MCO's non metal disruptive jobs to the standard tier, permitting them report to MCO's CR. All 4.19/4.20 jobs and metal jobs have been excluded.

Summary by CodeRabbit

• Chores
• Refined job tier classifications for Machine Config Operator-related tests with granular control by specific platform variants and software releases.
• Updated default handling for MCO-related jobs to improve resource allocation.
• Expanded test configuration entries for specific platform types and upgrade paths in CI infrastructure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

Scheduling required tests:
/test e2e

[djoshy]

Updated to include 4.22 cloud periodics.

[djoshy]

/test unit

[openshift-ci-robot]

Scheduling required tests:
/test e2e

[openshift-ci-robot]

@djoshy: This pull request references MCO-1968 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This sets all of MCO's non metal 4.21 & 4.22 disruptive jobs to the standard tier, permitting them report to MCO's CR. All 4.19/4.20 jobs and metal jobs have been excluded.

Summary by CodeRabbit

• Chores
• Refined job tier classifications for Machine Config Operator-related tests with granular control by specific platform variants and software releases.
• Updated default handling for MCO-related jobs to improve resource allocation.
• Expanded test configuration entries for specific platform types and upgrade paths in CI infrastructure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[isabella-janssen]

/lgtm

Looks good to me from the MCO side. Thank you @djoshy 🎉

[djoshy]

/unhold

[djoshy]

/test all

[xueqzhan]

Some comments. Unit test seems to be failing too.

[xueqzhan]

Passing rates for a few jobs are still pretty low (i.e. vsphere):

[djoshy]

The vsphere suite seems to be recovering - would it be okay to keep that in candidate and bump the rest to standard instead? I am unsure why the unit is failing, will investigate!

[xueqzhan]

I will group all standard in the standard section above. Also I only see one job run for e2e-aws-ovn-ocl in sippy in the last 7 days and it failed.

[djoshy]

Ah, sorry - meant to keep these in candidate, we don't really monitor these for CR at the moment.

[djoshy]

Ah, I forgot rebase for the unit, that should be fixed now 😄

[openshift-ci-robot]

Scheduling required tests:
/test e2e

[xueqzhan]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, isabella-janssen, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [xueqzhan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@djoshy: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.