OADP-7543: Optimize VSC handle readiness polling for VSS backups

[sseago]

Thank you for contributing to Velero!

Please add a summary of your change

This change adds more frequent (every one second) polling for the first 10 seconds that the CSI plugin waits for the snaphandle to appear. The prior 5-second polling interval resulted in multi-volume VMs taking more than 10 seconds to back up, at which point VSS would force an unfreeze too soon.

Does your change fix a particular issue?

OADP-7543

[openshift-ci-robot]

@sseago: This pull request references OADP-7543 which is a valid jira issue.

Details

In response to this:

Thank you for contributing to Velero!

Please add a summary of your change

This change adds more frequent (every one second) polling for the first 10 seconds that the CSI plugin waits for the snaphandle to appear. The prior 5-second polling interval resulted in multi-volume VMs taking more than 10 seconds to back up, at which point VSS would force an unfreeze too soon.

Does your change fix a particular issue?

OADP-7543

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 48a8404f-395c-42d2-8100-ede3b745f5a1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan for PR comments

• Generate coding plan

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sseago]

Leaving as draft for now until the upstream fix merges.

[sseago]

Upstream solution will be configurable (and disabled by default). We also need to decide whether we want that fix in OADP-1.5 or whether we want this simpler fix.

• Without it being configurable, we don't need any DPA changes, but there could be a performance impact for backups with a large number of volumes, and this fix is unnecessary for users that don't use VSS
• If we make it configurable, we need to add a DPA field to control it.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@sseago: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.