utilities/openstack: Fix handling of unit.run for CA check#1174
Open
fnordahl wants to merge 2 commits intoopenstack-charmers:masterfrom
Open
utilities/openstack: Fix handling of unit.run for CA check#1174fnordahl wants to merge 2 commits intoopenstack-charmers:masterfrom
fnordahl wants to merge 2 commits intoopenstack-charmers:masterfrom
Conversation
fnordahl
force-pushed
the
juju3x
branch
3 times, most recently
from
87a745f to
d0ee4d5
Compare
fnordahl
force-pushed
the
juju3x
branch
4 times, most recently
from
4afc0cc to
5ba8f4c
Compare
The `async_block_until_ca_exists` function makes direct use of the libjuju APIs which changed in Juju 3.x. Use the action normalise helper from the Zaza model module to reconcile. Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com>
The vault charm will expect the ``force`` parameter to be set to 'true' on consecutive runs of the ``get-csr`` or ``regenerate-intermediate-ca`` actions.
freyes
requested changes
Mar 4, 2024
| :returns: Action object | ||
| :rtype: juju.action.Action | ||
| """ | ||
| action_params={} |
Member
There was a problem hiding this comment.
zaza/openstack/charm_tests/vault/utils.py:487:18: E225 missing whitespace around operator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
async_block_until_ca_existsfunction makes direct use of the libjuju APIs which changed in Juju 3.x.Use the action normalise helper from the Zaza model module to reconcile.