[stable/caracal] machine_os: Preemptively load vfio kernel module.#682
Merged
mkalcok merged 2 commits intoopenstack-charmers:stable/caracalfrom May 8, 2025
Merged
Conversation
Flake8 started to complain about unused 'global' and 'nonlocal' annotations (F842). Their usage fell into three categories: * variable was not assigned to after declaring it with 'global'. * function declared variable as 'global' before returning it. However, this does not make returned value "globally writable" * declaring 'global' for sets and dicts before modifying them. This is not necessary. These structures are globally mutable even without the 'global' statement. (cherry picked from commit b20ec47) Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com>
VFIO kernel module is not always loaded, which causes tests to fail when they try to set No-IOMMU mode. This change calls modprobe to ensure that VFIO is loaded before we try to use it. (cherry picked from commit 0a01a10) Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com>
mkalcok
merged commit ffdc866
into
openstack-charmers:stable/caracal
16 of 18 checks passed
mkalcok
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #678