Add retry mechanism for the Launchpad API#686
Open
wilkmar wants to merge 1 commit intoopenstack-charmers:masterfrom
Open
Add retry mechanism for the Launchpad API#686wilkmar wants to merge 1 commit intoopenstack-charmers:masterfrom
wilkmar wants to merge 1 commit intoopenstack-charmers:masterfrom
Conversation
Quite often Launchpad API is temporarily unavailable. In such cases, without this patch, a request to get all Ubuntu releases from Launchpad fails immediately, causing the entire test to fail. For example for the charm-octavia it can take up to 2 hours before the functional tests get to this point. And if it fails because of the Launchapad API unavailability, the whole tests suite needs to be restarted. In order to save time and resources, a simple request retry mechanism is introduced by this patch. Signed-off-by: Marcin Wilk <marcin.wilk@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite often Launchpad API is temporarily unavailable. In such cases, without this patch, a request to get all Ubuntu releases from Launchpad fails immediately, causing the entire test to fail. For example for the charm-octavia it can take up to 2 hours before the functional tests get to this point. And if it fails because of the Launchapad API unavailability, the whole tests suite needs to be restarted. In order to save time and resources, a simple request retry mechanism is introduced by this patch.