no-wait option in tests.yaml by hemanthnakkina · Pull Request #688 · openstack-charmers/zaza

hemanthnakkina · 2026-03-26T16:31:49Z

To run multiple bundles in different models, zaza
need to wait for first bundle applications to acheive status as specified in target_deploy_status before deploying second bundle using configure. (Deploying second bundle using configure is actually a hacky
way). This increases the time of deployment as both bundles are deployed sequentially. sunbeam-charms
project has total timeout of 2 hours for its
functional test.

Add option no-wait in tests.yaml so that zaza did not wait for target_deploy_status for the applications and proceed with configure.

tests_options:
  no_wait_deploy:
    - smoke

The option --no-wait already exists for functest-deploy cli command.

To run multiple bundles in different models, zaza need to wait for first bundle applications to acheive status as specified in target_deploy_status before deploying second bundle using configure. (Deploying second bundle using configure is actually a hacky way). This increases the time of deployment as both bundles are deployed sequentially. sunbeam-charms project has total timeout of 2 hours for its functional test. Add option no-wait in tests.yaml so that zaza did not wait for target_deploy_status for the applications and proceed with configure. tests_options: no_wait_deploy: smoke The option --no-wait already exists for functest-deploy cli command.

Copilot

Pull request overview

Adds a tests_options.no_wait_deploy setting in tests.yaml to allow selectively skipping deployment waiting so multi-bundle functional test runs can proceed to configuration sooner and reduce overall runtime.

Changes:

Introduces utils.no_wait_deploy() to read tests_options.no_wait_deploy (per bundle).
Wires the option into func_test_runner.run_env_deployment() to pass wait= into deploy.deploy() and to conditionally skip the post-deploy settle wait.
Adds unit tests for the new config option and runner behavior; documents the new tests.yaml option.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
zaza/charm_lifecycle/utils.py	Adds `no_wait_deploy()` config helper for reading `tests_options.no_wait_deploy`.
zaza/charm_lifecycle/func_test_runner.py	Applies `no_wait_deploy` to deployment waiting behavior in the lifecycle runner.
unit_tests/test_zaza_charm_lifecycle_utils.py	Adds unit coverage for `no_wait_deploy()` config parsing behavior.
unit_tests/test_zaza_charm_lifecycle_func_test_runner.py	Updates expected deploy calls to include `wait=...` and adds a no-wait runner test.
doc/source/addingcharmtests.rst	Documents the new `tests_options.no_wait_deploy` option.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-27T09:20:10Z

doc/source/addingcharmtests.rst

+state. This is equivalent to passing ``--no-wait`` directly to
+``functest-deploy``.


The new docs state this option is equivalent to passing --no-wait to functest-deploy, but the implementation also skips the additional post-deploy block_until_all_units_idle settle step in func_test_runner.run_env_deployment. Either update the docs to describe the extra behavior (and drop the equivalence claim), or change the runner to still perform the model-settle wait even when skipping target_deploy_status waiting.

Suggested change

state. This is equivalent to passing ``--no-wait`` directly to

``functest-deploy``.

state or for the model to settle (the additional post-deploy

``block_until_all_units_idle`` wait is also skipped).

Copilot · 2026-03-27T09:20:10Z

doc/source/addingcharmtests.rst

+In the ``tests.yaml`` the option is added as a list item::
+
+    charm_name: vault
+    gate_bundles:
+    - focal-ussuri
+
+    target_deploy_status:
+      vault:
+        workload-status: blocked
+        workload-status-message: Vault needs to be initialized
+
+    tests_options:
+      no_wait_deploy:
+        - focal-ussuri
+


The PR description example shows tests_options.no_wait_deploy: - smoke, but the implemented behavior (and this doc example) expects a list of bundle names (e.g. focal-ussuri). If smoke/dev/gate selectors were intended, the code needs to be adjusted; otherwise please update the PR description/example to avoid confusion.

Copilot · 2026-03-27T09:20:10Z

zaza/charm_lifecycle/utils.py

+    """Ask if the wait step should be skipped after deploying bundle.
+
+    Setting no_wait_deploy for a bundle means that zaza will not wait for
+    the applications to reach the states defined in target_deploy_status (or
+    active/idle) after deploying the bundle.


no_wait_deploy is described here as skipping only the target_deploy_status/active-idle wait, but in func_test_runner.run_env_deployment the same flag is also used to skip the post-deploy block_until_all_units_idle settle step. Please clarify the docstring to match the actual behavior (or adjust the runner if the settle wait should still occur).

Suggested change

"""Ask if the wait step should be skipped after deploying bundle.

Setting no_wait_deploy for a bundle means that zaza will not wait for

the applications to reach the states defined in target_deploy_status (or

active/idle) after deploying the bundle.

"""Ask if the deploy wait/settle steps should be skipped for a bundle.

Setting no_wait_deploy for a bundle means that zaza will not:

* wait for the applications to reach the states defined in

target_deploy_status (or active/idle) after deploying the bundle; or

* perform the post-deploy block_until_all_units_idle "settle" wait.

Copilot · 2026-03-27T09:20:11Z

zaza/charm_lifecycle/func_test_runner.py

        # When deploying bundles with cross model relations, hooks may be
-        # triggered in already deployedi models so wait for all models to
+        # triggered in already deployed models so wait for all models to
        # settle.
        for deployment in env_deployment.model_deploys:
+            if utils.no_wait_deploy(deployment.bundle):
+                logging.info(
+                    "Skipping post-deploy wait for {} "
+                    "(no_wait_deploy is set)".format(
+                        deployment.model_name))
+                continue


The comment says we must “wait for all models to settle” for cross-model relations, but the new no_wait_deploy check skips the settle wait (block_until_all_units_idle) entirely for those deployments. Either update the explanatory comment to reflect the conditional behavior, or reconsider skipping this settle step since it’s specifically meant to avoid cross-model hook races.

freyes · 2026-03-27T13:34:07Z

doc/source/addingcharmtests.rst

+
+    tests_options:
+      no_wait_deploy:
+        - focal-ussuri


zaza supports adding a bundle with a prefix , e.g. https://github.com/openstack-charmers/charmed-openstack-tester/blob/master/tests/distro-regression/tests/tests.yaml#L5 , will this option honor it?

gate_bundles: - security:focal-ussuri - focal-ussuri test_options: no_wait_deploy: - focal-ussuri

in a tests.yaml like this ^, the no-wait should only match the second bundle and not security:focal-ussuri

hemanthnakkina force-pushed the no-wait-tests-yaml branch from aca7203 to 869a40a Compare March 26, 2026 17:16

gboutry requested review from Copilot and freyes March 27, 2026 09:15

Copilot started reviewing on behalf of gboutry March 27, 2026 09:15 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

freyes requested changes Mar 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

no-wait option in tests.yaml#688

no-wait option in tests.yaml#688
hemanthnakkina wants to merge 1 commit intoopenstack-charmers:masterfrom
hemanthnakkina:no-wait-tests-yaml

hemanthnakkina commented Mar 26, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 27, 2026

Uh oh!

Copilot AI Mar 27, 2026

Uh oh!

Copilot AI Mar 27, 2026

Uh oh!

Copilot AI Mar 27, 2026

Uh oh!

freyes Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		state. This is equivalent to passing ``--no-wait`` directly to
		``functest-deploy``.

-    """Ask if the wait step should be skipped after deploying bundle.
-    Setting no_wait_deploy for a bundle means that zaza will not wait for
-    the applications to reach the states defined in target_deploy_status (or
-    active/idle) after deploying the bundle.
+    """Ask if the deploy wait/settle steps should be skipped for a bundle.
+    Setting no_wait_deploy for a bundle means that zaza will not:
+      * wait for the applications to reach the states defined in
+        target_deploy_status (or active/idle) after deploying the bundle; or
+      * perform the post-deploy block_until_all_units_idle "settle" wait.

Conversation

hemanthnakkina commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

freyes Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hemanthnakkina commented Mar 26, 2026 •

edited

Loading