Add new download cache validation #3528
Conversation
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2c53f4d440414a5097bdb17c5dcfe02d ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 11m 57s |
drosenfe
force-pushed
the
downloadcache
branch
from
ea1e7d1 to
5f80c3e
Compare
This validation verifies that user may specify rpms and container images for download and caching on a compute node. After a deployment is executed it is verified that the proper rpms and container images are present in the compute node cache. Signed-off-by: David Rosenfeld <drosenfe@redhat.com>
drosenfe
force-pushed
the
downloadcache
branch
from
5f80c3e to
299c8c1
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| cifmw.general.ci_script: | ||
| output_dir: "{{ cifmw_validations_basedir }}/artifacts" | ||
| script: >- | ||
| oc patch -n {{ cifmw_validations_namespace }} osdpns/"{{ deployed_nodeset_name.stdout | trim }}" --type json --patch '[{ "op": "add", "path": "/spec/nodeTemplate/ansible/ansibleVars/edpm_download_cache_running_services","value": {{ cifmw_validations_cache_run_services }} }]' |
There was a problem hiding this comment.
This var shouldn't need to be set. It's set by the edpm_download_cache role from either edpm_services_override, or edpm_services, both of which of those are set automatically by openstack-operator.
There was a problem hiding this comment.
Yes, this was here because of: https://issues.redhat.com/browse/OSPRH-21737 Now that we know a fix is coming will remove this and let the role populate it automatically.
| nodeSets: | ||
| - "{{ deployed_nodeset_name.stdout | trim }}" | ||
| servicesOverride: | ||
| - download-cache |
There was a problem hiding this comment.
Here you want to also list bootstrap and frr
This will ensure that edpm_download_cache_running_services gets set automatically by the role with download-cache, bootstrap, and frr.
There was a problem hiding this comment.
bootstrap can be added. Will look some more at frr.
4 participants
This validation verifies that user may specify rpms and container images for download and caching on a compute node. After a deployment is executed it is verified that the proper rpms and container images are present in the compute node cache.