[multiple] Update no_log to use cifmw_nolog variable
#3544
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
rebtoor
force-pushed
the
update_no_log
branch
from
daa1a80 to
8c30e12
Compare
|
Any specific reason to not include this var in group_vars? |
@amartyasinha none from my pov. But with this PR I was just trying to address all those cases where the variable was hardcoded to |
This change enhances the debugging experience and ensures conistent usage of the no_log variable throughout the CI Framework repository. Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
rebtoor
force-pushed
the
update_no_log
branch
2 times, most recently
from
5a87cd8 to
a7aa470
Compare
Its default value is set to true to avoid logging of sensitive data by default. It can be overridden by setting it to false. Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
rebtoor
force-pushed
the
update_no_log
branch
from
a7aa470 to
3d9f1cf
Compare
|
@amartyasinha fixed with 3d9f1cf :) |
|
(non-blocking) question: I'm unsure now if we want to set in each of the default of the var as we're moving it to the group_vars. |
|
recheck |
3 participants
This change enhances the debugging experience and ensures conistent usage of the
no_logvariable throughout the CI Framework repository.