(multiple) Ansible Core 2.17.14 #3571
Open
+18
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert _file_list to YAML to ensure loop receives a list type instead of string. Ansible 2.16+ enforces strict type checking for loop values. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Sergii Golovatiuk <sgolovat@redhat.com>
Wrap Jinja2 variable assignments in proper template syntax to ensure conditionals evaluate to boolean values. Ansible 2.16+ requires explicit boolean results in when clauses. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Sergii Golovatiuk <sgolovat@redhat.com>
Use ternary filter to convert ansible.utils.ipaddr result to explicit boolean. Ansible 2.16+ requires conditionals to evaluate to true/false, not truthy/falsy values. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Sergii Golovatiuk <sgolovat@redhat.com>
Add list filter to range() output to ensure loop receives a proper list type. Ansible 2.16+ does not support range objects directly as loop values. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Sergii Golovatiuk <sgolovat@redhat.com>
Replace truthy check with explicit 'is not none' and length check. Ansible 2.16+ requires conditionals to return boolean values, not NoneType. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Sergii Golovatiuk <sgolovat@redhat.com>
Remove regex replacement that converted list to string format. The variable should remain as a list for proper loop iteration in Ansible 2.16+. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Sergii Golovatiuk <sgolovat@redhat.com>
Use default(false) and bool filter to ensure conditional returns boolean even when variable is undefined. Ansible 2.16+ does not allow NoneType in conditional evaluation. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Sergii Golovatiuk <sgolovat@redhat.com>
Define cifmw_libvirt_manager_compute_* variables explicitly to prevent template evaluation errors during fact gathering. When the scenario overrides cifmw_libvirt_manager_configuration, Ansible evaluates Jinja2 expressions before va-common.yml variables are in scope. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Sergii Golovatiuk <sgolovat@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
danpawlik
requested changes
Dec 18, 2025
Contributor
danpawlik
left a comment
danpawlik
left a comment
There was a problem hiding this comment.
Since our Zuul is using 2.15.3, we would like to stay with that version, even when many of our playbooks uses nested ansible execution.
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches are required to switch ansible from 2.15 to 2.17.4