Appcred #599
Appcred #599
Conversation
Implement AppCred support following patterns from barbican-operator: Controllers (HeatAPI, HeatCfnAPI, HeatEngine): - Add AC verification call in reconcileNormal using VerifyApplicationCredentialsForService - Add acSecretFn watcher to trigger reconciliation when ac-heat-secret changes - Register AC secret watcher in SetupWithManager Configuration template (templates/heat/config/00-default.conf): - Update [trustee] section with conditional AC/password authentication - Update [keystone_authtoken] section with conditional AC/password authentication - Use v3applicationcredential auth_type when AC secret exists Template parameter generation (heat_controller.go): - Check for ac-heat-secret in generateServiceSecrets - Set UseApplicationCredentials, ACID, and ACSecret template parameters - Fall back to password authentication if AC secret doesn't exist Functional tests: - Add test case for Heat with ApplicationCredential - Verify config contains application_credential_id and application_credential_secret - Verify auth_type=v3applicationcredential is used
The test was incorrectly checking that [trustee] section shouldn't exist. The section should exist but use v3applicationcredential auth_type instead of password auth_type.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: afaranha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@afaranha: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4248289017a64ac8aedff78937ca34b5 ❌ openstack-k8s-operators-content-provider FAILURE in 8m 56s |
|
Closing in favor of #600 |
2 participants
No description provided.