Identify & Remedy Duplicate Sponsors#347
Open
NewAgeAirbender wants to merge 3 commits intoopenstates:developfrom
Open
Identify & Remedy Duplicate Sponsors#347NewAgeAirbender wants to merge 3 commits intoopenstates:developfrom
NewAgeAirbender wants to merge 3 commits intoopenstates:developfrom
Conversation
jamesturk
reviewed
Sep 15, 2021
Member
jamesturk
left a comment
There was a problem hiding this comment.
this seems really useful, but we'll need to figure out a few things on the backend before we can merge:
- having two users with the same ID present in their additional IDs causes issues when we attempt to look up by ID, so we need to avoid that
- the right thing to do here is to delete the less-used ID and alias it to the more used ID
- that'd require us adding code for deletion, which isn't present yet
maybe next week we can sync on this a bit more to discuss options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a page where people can submit match requests between multiple sponsor options for the matcher. Users can submit as many duplicates as they think are right, immediately goes to a pr with an appended name and id for that person.
Example: someone added a middle initial to a name, so there exists both a "Richard P. Creagan" and "Richard Creagan" (HI), or 2 "Sonya Jaquez Lewis"s (CO) with different OS ids.
@jamesturk