Use MathJax 4 #85
Open
Use MathJax 4 #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I created an issue for the empty mtr problem here. I think the workaround is fine for production. It's just a little annoying that we will have some extra non-fatal errors in the logs. |
This works for tagged pdfs, the other doesn't. Browsers also recognize title as a valid alternate description + add a tooltip.
So far, this only happens when a math element only contains mspace and nothing else.
Event emitter had some problems with serializing the DOM.
Not always one svg (oops)
Dantemss
approved these changes
Oct 27, 2025
| log.debug(`There are ${total} elements to process...`) | ||
| const convertMathML = async (log, mathEntries, outputFormat, batchSize, handleErrors) => { | ||
| log.debug(`There are ${mathEntries.length} elements to process...`) | ||
| log.debug('Starting conversion of mapped MathML elements with mathjax-node...') |
There was a problem hiding this comment.
I guess technically you removed mathjax-node
serializes entities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/CORE-1294
Update to MathJax 4 in order to fix speech generation. There's one workaround for dealing with empty mtr. Also, I removed html output since we are not using that. It shouldn't be too hard to add it back, but it didn't seem worth it right now.
There are some visual differences since the font is slightly different, but I tried to keep it as close to the old as possible. I was able to configure the min script size in the
readysection of the config instead of using an extension.The missing font variants part I am less sure about. I have some idea how to replicate that in MathJax 4 using fontparams, but I am not sure if that's still required.