multipath-tools 0.14.2 #140
Merged
+373
−202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purge_disconnected only works on paths that are part of a multipath device. However, get_new_state() is also run on uninitialized paths that are not part of any multipath device, and the purge_disconnected code in it was dereferencing pp->mpp, without checking if it was NULL. Fix that. Fixes: 690550a ("multipathd: implement purge functionality for disconnected paths") Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> Reviewed-by: Martin Wilck <mwilck@suse.com>
If kpartx crashes and the cleanup action isn't yet pushed, the cleanup will fail. Signed-off-by: Martin Wilck <mwilck@suse.com>
If our kpartx binary is broken, it's better to use the system kpartx for cleanup, if possible. Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
mwilck
force-pushed
the
queue
branch
3 times, most recently
from
00c5b28 to
44ea9e0
Compare
If something goes wrong, it's useful to see the current loop device and dm device setup on the system. Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
Make this output better readable and understandable. Signed-off-by: Martin Wilck <mwilck@suse.com>
If run directly from the kpartx subdirectory, execute the local kpartx binary. Signed-off-by: Martin Wilck <mwilck@suse.com>
Mostly missing quotes. SC2016 must be generally disabled because it will complain about every push_cleanup invocation. SC2086 produces false positives for KPARTX_OPTS. Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
"which" may not always be awailable. Signed-off-by: Martin Wilck <mwilck@suse.com>
The usleep command may not always be available. Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
parted has functionalilty to create partition mappings, which is not desired in our case. Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
This test must be run as root. Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
In the opensvc/multipath-tools repository, we use "master" as the reference branch for the ABI check, but we didn't run it for pushes to "master" so far (a merge into "master" seems to count as "push"). Therefore, the reference ABI was missing unless it had been triggered manually for "master, and the workflow failed. Run "abi.yaml" for every merge to master. Signed-off-by: Martin Wilck <mwilck@suse.com>
... and only rebuild it if necessary Signed-off-by: Martin Wilck <mwilck@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multipath-tools 0.14.2, 2026/01
Bug fixes
Fixes 0.14.0. Commit 86ff48b.
CI
test_kpartxtest script, and added it to thebasic-build-and-ciworkflow.Shortlog
@bmarzins (1):
multipathd: fix possible null deference in purge_disconnected code
@mwilck (21):
test_kpartx: add cleanup action before running kpartx
test_kpartx: Use system kpartx for cleanup
test_kpartx: hide dd output
test_kpartx: add function to debug current system state
test_kpartx: run cleanly on systems using lvmdevices
test-kpartx: use more unusual VG and LV names
test-kpartx: improve output for errors and cleanup
test-kpartx: support running from kpartx subdirectory
test-kpartx: fix shellcheck-reported problems
test-kpartx: make partition renaming test more robust
test-kpartx: use "command -v" instead of "which"
test-kpartx: use sleep for microsecond sleep
test-kpartx: also add trap for signals
test-kpartx: use sfdisk instead of parted
test-kpartx: improve step descriptions to ease debugging
kpartx/Makefile: add test target to run test-kpartx
kpartx/Makefile: enable debugging for test-kpartx
GitHub workflows: add kpartx test to build-and-unittest.yaml
Update NEWS.md for 0.14.2
libmultipath: bump version to 0.14.2
GitHub workflows: run abi.yaml for pushes on "master", too
GitHub workflows: abi-stable: try to download the artifact