Open
Conversation
project-defiant
requested changes
Apr 1, 2025
Collaborator
project-defiant
left a comment
There was a problem hiding this comment.
This PR will require additional changes to the gentropy.yaml and pis.yaml
- Ideally we want to move the interval raw sources to the
$release_bucket/input/intervalwith PIS. Have a look at pis.yaml - After having raw intervals in the
input/intervalswe want to refer to them from thegentropy.yamlin simillar way how you defined it in thegenetics_etl.yaml.
Note
genetics_etl.yaml is going to be superseded by gentropy.yaml once we define the development workflow for the orchestration and allow to run a subpart of the unified pipeline dag.
Collaborator
|
@xyg123 can you post into the PR the link to the execution of the |
Author
|
Successful run of interval step to generate interval index, took ~10 hours. |
Collaborator
|
@xyg123 we need to make some strategic decisions here, because we can not have a step that takes ~10h to calculate during each release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR adds the step config for running the interval index needed to generate interval features for L2G.
It processes the interval files from their raw format, then identifies interval regions that overlaps our variant index.