fix: resolving circular dependencies in MoA steps#69
Merged
Conversation
Contributor
Author
|
The resulting dataset looks good: |
Making input definition more explicit Co-authored-by: Irene López Santiago <45119610+ireneisdoomed@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Upon assembling the unified pipeline, it was apparent that the rewrite introduced a circular dependency. Mechanism of action required target, target required safety, safety requires pharmacogenomics, pharmacogenomics requires mechanism of action.
We decided to use the intermediate target/ensembl dataset as it already contains swissprot and trembl protein identifiers that are used to link ChEMBL target with our target index.
!! This is a temporary solution, the real solution is to separate target etl step from unnecessary annotations.