Introduce netuid generation for storage cleaning#2592
Open
evgeny-s wants to merge 3 commits intodevnet-readyfrom
Open
Introduce netuid generation for storage cleaning#2592evgeny-s wants to merge 3 commits intodevnet-readyfrom
evgeny-s wants to merge 3 commits intodevnet-readyfrom
Conversation
Contributor
|
Thanks for the solution, I am wondering if we really need it. After we get next generation netuid, the data related old generation is not useful and never can be updated by any transaction. We can remove them all. And I don't think there will be much data for this map in the real production env. |
open-junius
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Iterating an unbounded
StorageDoubleMapis unsafe, so instead of clearing state, we make stale state unreachable.Design
pallet_subtensor::NetuidGeneration: Map<NetUid, u64>, bumped on everydo_register_network.AllowancesStoragesecondary key changes from(spender, netuid)to(spender, netuid, generation).approve,allowance,increaseAllowance,decreaseAllowance, andtransferStakeFromread the current generation frompallet_subtensorand mix it into the key.netuidis deregistered and re-registered, the generation differs, so entries written under the previous lifetime land at an unreachable key, and all reads through the precompile default to0(ValueQuery).Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.