Fix topicmap colours disappearing when switching between search tabs#23
Open
tung-jin-chew-hp wants to merge 2 commits intoopentext-idol:developfrom
Open
Fix topicmap colours disappearing when switching between search tabs#23tung-jin-chew-hp wants to merge 2 commits intoopentext-idol:developfrom
tung-jin-chew-hp wants to merge 2 commits intoopentext-idol:developfrom
Conversation
… on a saved search, tested in Firefox/IE11/Chrome
tung-jin-chew-hp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is that the fill URL is bound to the page location; which changes when the active tab changes. The most sensible way seems to be to leave out the URL entirely, and just use the '#id' reference instead of 'url#id'; but this requires patching Raphael.js, so we add a local clone and edit it.