Fixing broken sdsp_track_with_bluesky_sim test #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to run this test, some objects appear to mismatch. This fixes it
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a broken test in test_sdsp_track_with_bluesky_sim.py by correcting object attribute references and method calls that were causing failures.
Changes:
- Added
StepResultimport and type annotation for proper type handling - Fixed incorrect attribute access from
result.detailstoresult.resultto match theStepResultmodel - Replaced non-existent
fb_client.wait_x_seconds()calls with standardasyncio.sleep()calls
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RomanPszonka
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to run this test, some objects appear to mismatch. This fixes it