feat(dhw): expose operation mode #575
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CFenner
reviewed
Aug 25, 2025
Member
CFenner
left a comment
CFenner
left a comment
There was a problem hiding this comment.
Please remove the value from the ignore list in TestForMissingProperties and add a test case (e.g.
PyViCare/tests/test_VitovalorPT2.py
Lines 65 to 66 in eb922bb
CFenner
changed the title
CFenner
reviewed
Nov 13, 2025
Comment on lines
+165
to
+168
| @handleNotSupported | ||
| def getDomesticHotWaterOperatingMode(self): | ||
| return self.service.getProperty("heating.dhw.operating.modes.active")["properties"]["value"]["value"] | ||
|
|
Member
There was a problem hiding this comment.
I think we should update the getDomesticHotWaterActiveMode function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added getDomesticHotWaterOperatingMode which compliments setDomesticHotWaterOperatingMode. Returns "eco" or "comfort".