add get-method to read solar cumulative production #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I also wanted to add a test case, but this data point is not included in tests/response/Solar.json |
Member
Can you update the data with a set from your system? |
CFenner
reviewed
Sep 15, 2025
|
|
||
| @handleNotSupported | ||
| def getSolarPowerProductionCumulativeProduced(self): | ||
| return self.service.getProperty("heating.solar.power.cumulativeProduced")["properties"]["value"]["value"] |
Member
There was a problem hiding this comment.
Please verify if this is excluded in
https://github.com/openviess/PyViCare/blob/master/tests/test_TestForMissingProperties.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a method to read the cumulative thermal solar production.
Closes #596