-
Notifications
You must be signed in to change notification settings - Fork 3
Add IOS Support in the document #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add IOS Support in the document #30
Conversation
Signed-off-by: Ever Morales <ever.morales@koombea.com>
3d03195 to
32a1dbf
Compare
|
|
||
| #### **Step 1: Configure Info.plist** | ||
|
|
||
| The iOS app requires URL scheme configuration in `Info.plist`. Add the following to handle deep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of the readers are android engineers, do you mind adding more explanation about Info.plist, for example :what it contians ,what it can do?
thanks
| fun HandleUrl(url: String) { | ||
| val credentialOffers = globalCredentialOffers | ||
| if (credentialOffers == null) { | ||
| Logger.w(TAG, "HandleUrl: credentialOffers channel not yet initialized, URL will be ignored: $url") | ||
| return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add TODO here (TODO inside or outside of handleUrl function, the difference between code-starter branch and main branch is code-starter has TODO)? also please modify the related code in code-starter branch.
Thanks
| 1. **Open in Xcode**: Navigate to `iosApp → iosApp.xcodeproj` (tested with Xcode 16.3) | ||
| 2. **Clean Build**: In Xcode, go to **Product → Clean Build Folder** | ||
| 3. **Run**: Click **Start the Active Scheme** to build and run the app | ||
| 4. The app will install on your iOS device or simulator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, i don't think iOS simulator works. The reason is the credentail will be stored in hardware related place. (It is just my guess ,do you mind testing it?)
If simulator can't work, please emphasis it on doc.
Thanks
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just like above ,as TODO here (inside or outside of the function)? (also modify code-starter branch), thanks
| 2. Host an `apple-app-site-association` file at | ||
| `https://apps.multipaz.org/.well-known/apple-app-site-association`: | ||
|
|
||
| * Requires .well-known/assetlinks.json on the server | ||
| * Must include your app's signing certificate fingerprint | ||
| * Android automatically verifies the trust relationship | ||
| ```json | ||
| { | ||
| "applinks": { | ||
| "apps": [], | ||
| "details": [ | ||
| { | ||
| "appID": "TEAM_ID.org.multipaz.samples.wallet.cmp", | ||
| "paths": ["/landing/*"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicated with 6.3.3?
| **For HTTPS Universal Links (Optional - Higher Security):** | ||
|
|
||
| #### **6.1 App Link Verification and Trust** | ||
| 1. Add Associated Domains to your app's entitlements (`iosApp.entitlements`): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicated with 6.3.2?
hanluOMH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add reviews
VishnuSanal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@TheBlackBit , Make sure the codelab and the doc are the same |
IOS Support Added for Holder CodeLab getting credentials.
https://theblackbit.github.io/multipaz-developer-website/