Refactor to use kotlinx.navigation3 for upstream compatibility. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koukarine
force-pushed
the
nav3
branch
3 times, most recently
from
8362c58 to
111ab20
Compare
Additionally, fixed problems in composables with JSON animations (error_animation, success_animation, nfc_animation, and waiting_animation) caused by the recomposition happening almost every animation frame by replacing original property delegates (by) in favor of keeping and passing around the corresponding state object. That prevents app performance degradation and occasional app crashes observed in a downstream impl. Tested for UI flows being the same as original or better on Android and iOS devices. Signed-off-by: koukarine <koukarine@google.com>
davidz25
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested for UI flows same as original (main br.) or better on Android and iOS devices.
Tested basic app functionality to match the original.
Fixes #12