Skip to content

[WIP] Move dns_instrument from onCompleted to onHeadersReceived#1021

Draft
englehardt wants to merge 7 commits intomasterfrom
dns_instrument_fix
Draft

[WIP] Move dns_instrument from onCompleted to onHeadersReceived#1021
englehardt wants to merge 7 commits intomasterfrom
dns_instrument_fix

Conversation

@englehardt
Copy link
Collaborator

Fixes #1020 WIP. I haven't tested this much.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.74%. Comparing base (7b8cf99) to head (8a855a4).
⚠️ Report is 35 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1021   +/-   ##
=======================================
  Coverage   45.74%   45.74%           
=======================================
  Files          35       35           
  Lines        3478     3478           
=======================================
  Hits         1591     1591           
  Misses       1887     1887           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vringar
Copy link
Contributor

vringar commented Jan 12, 2023

Good Catch! Does this also resolve the issue where DNS requests for domains that don't resolved aren't captured?

@englehardt
Copy link
Collaborator Author

I'm not sure. I'll need to write a test page for both of these conditions.

@vringar vringar force-pushed the dns_instrument_fix branch from 159c5fa to 628e3f3 Compare February 7, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DNS Instrument only records the final request in a redirect chain

3 participants