docs: fix stale references and fill in missing documentation#1120
Open
docs: fix stale references and fill in missing documentation#1120
Conversation
vringar
force-pushed
the
docs/fix-stale-references
branch
2 times, most recently
from
48dc880 to
0657877
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1120 +/- ##
==========================================
+ Coverage 35.19% 37.32% +2.12%
==========================================
Files 35 35
Lines 3475 3475
==========================================
+ Hits 1223 1297 +74
+ Misses 2252 2178 -74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Fix headless parameter: 'headless' browser param → display_mode = "headless" - Fix DataAggregator paths → openwpm/storage/ (README and Platform-Architecture) - Fix BrowserManager.py → browser_manager.py - Fix SocketInterface.py → socket_interface.py - Fix typo: you're → your
- Specify Ubuntu versions: 24.04 for CI, 22.04 for Docker - Fill in TODO instrument docs: navigation_instrument, callstack_instrument, dns_instrument - Mark callstack_instrument as broken (matches config.py validation) - Update Selenium 3 reference and fix docs URL - Add Platform Configuration Options section to Configuration.md - Fix 'enviroment' typo in CONTRIBUTING.md
vringar
force-pushed
the
docs/fix-stale-references
branch
from
dbaf289 to
0b94240
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect file paths, outdated references, and fill in missing documentation sections.
First commit fixes wrong paths (DataAggregator → storage/, BrowserManager.py → browser_manager.py, etc.) and a couple of typos.
Second commit fills in the TODO instrument descriptions, adds Platform Configuration Options, and updates stale version references.