Skip to content

dns: check there is room in answer packet #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MattCatz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dns: check there is room in answer packet #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion dns.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,13 +150,18 @@ bool dns_packet_question(const char *name, int type)
return true;
}

void dns_packet_answer(const char *name, int type, const uint8_t *rdata, uint16_t rdlength, int ttl)
bool dns_packet_answer(const char *name, int type, const uint8_t *rdata, uint16_t rdlength, int ttl)
{
struct dns_answer *a;

pkt.h.flags |= cpu_to_be16(0x8400);

a = dns_packet_record_add(sizeof(*a) + rdlength, name);
if (!a) {
DBG(0, "Not enough room for answer %d\n", be16_to_cpu(pkt.h.answers)+1);
return false;
}

memset(a, 0, sizeof(*a));
a->type = cpu_to_be16(type);
a->class = cpu_to_be16(1);
Expand All @@ -166,6 +171,7 @@ void dns_packet_answer(const char *name, int type, const uint8_t *rdata, uint16_
DBG(1, "A <- %s %s\n", dns_type_string(be16_to_cpu(a->type)), name);

pkt.h.answers += cpu_to_be16(1);
return true;
}

static void dns_question_set_multicast(struct dns_question *q, bool val)
Expand Down
2 changes: 1 addition & 1 deletion dns.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ extern int cfg_no_subnet;

void dns_packet_init(void);
bool dns_packet_question(const char *name, int type);
void dns_packet_answer(const char *name, int type, const uint8_t *rdata, uint16_t rdlength, int ttl);
bool dns_packet_answer(const char *name, int type, const uint8_t *rdata, uint16_t rdlength, int ttl);
void dns_packet_send(struct interface *iface, struct sockaddr *to, bool query, int multicast);

void dns_query(const char *name, uint16_t type);
Expand Down