dhcpv4: fix segfault when disabling interface#381
Open
mmmspatz wants to merge 1 commit intoopenwrt:masterfrom
Open
dhcpv4: fix segfault when disabling interface#381mmmspatz wants to merge 1 commit intoopenwrt:masterfrom
mmmspatz wants to merge 1 commit intoopenwrt:masterfrom
Conversation
Author
|
Supersedes #376 |
dhcpv4_free_lease already calls avl_delete() on the node it's freeing, and thus shouldn't be called inside an avl_remove_all_elements() loop. Use avl_for_each_element_safe() instead. Its documentation says: "This loop can be used if the current element might be removed from the tree during the loop." Fixes: openwrt#371 Signed-off-by: Mark H. Spatz <mark.h.spatz@gmail.com>
mmmspatz
force-pushed
the
mspatz/fix_avl_page_fault
branch
from
4bddf1a to
f641760
Compare
mmmspatz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dhcpv4_free_lease already calls avl_delete() on the node it's freeing, and thus shouldn't be called inside an avl_remove_all_elements() loop.
Use avl_for_each_element_safe() instead. Its documentation says: "This loop can be used if the current element might be removed from the tree during the loop."
Fixes: #371