libubus: Add UBUS_OBJECT() macro for initializing an ubus_object#8
Open
ksperling-apple wants to merge 1 commit intoopenwrt:masterfrom
Open
libubus: Add UBUS_OBJECT() macro for initializing an ubus_object#8ksperling-apple wants to merge 1 commit intoopenwrt:masterfrom
ksperling-apple wants to merge 1 commit intoopenwrt:masterfrom
Conversation
Especially in C++ (where depending on compiler settings, field order and completeness is enforced), initializing an ubus_object is a little tedious. Introduce an UBUS_OBJECT() macro that can be used to initialize an ubus_object with a name and type. The n_methods field is set to -1 to signal to ubus_add_object() that methods should be copied from the object type (if they haven't been changed in the meantime). Copying them from the type in UBUS_OBJECT() directly is not desirable because it would make for a non-constant initializer. Signed-off-by: Karsten Sperling <ksperling@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Especially in C++ (where depending on compiler settings, field order and completeness is enforced), initializing an ubus_object is a little tedious. Introduce an UBUS_OBJECT() macro that can be used to initialize an ubus_object with a name and type.
The n_methods field is set to -1 to signal to ubus_add_object() that methods should be copied from the object type (if they haven't been changed in the meantime). Copying them from the type in UBUS_OBJECT() directly is not desirable because it would make for a non-constant initializer.