config: Clarify config values and their relationships#3
Open
lowjoel wants to merge 1 commit intoopenwrt:masterfrom
Open
config: Clarify config values and their relationships#3lowjoel wants to merge 1 commit intoopenwrt:masterfrom
lowjoel wants to merge 1 commit intoopenwrt:masterfrom
Conversation
This shows how the different values must be set relative to each other so that the configs make sense. In the long term this should be implemented as checks in the config loading code and emit warnings, but documenting them is better than status quo at the moment. Signed-off-by: Joel Low <joel@joelsplace.sg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shows how the different values must be set relative to each other so that the configs make sense.
In the long term this should be implemented as checks in the config loading code and emit warnings, but documenting them is better than status quo at the moment.