policy: Account for band steering when selecting candidates#4
Draft
lowjoel wants to merge 1 commit intoopenwrt:masterfrom
Draft
policy: Account for band steering when selecting candidates#4lowjoel wants to merge 1 commit intoopenwrt:masterfrom
lowjoel wants to merge 1 commit intoopenwrt:masterfrom
Conversation
When choosing a better candidate for a client to roam to, consider the fact that the the client may also be band-steered to a different frequency after association. If the new AP has `assoc_steering` enabled, this may cause the client to attempt association, and fail associating which results in a kick from the original AP. This will cause the client to lose its association with the ESS. Signed-off-by: Joel Low <joel@joelsplace.sg>
lowjoel
commented
May 6, 2023
| } | ||
| } | ||
|
|
||
| bool usteer_band_steering_is_target(struct usteer_local_node *ln, struct usteer_node *node) |
Author
There was a problem hiding this comment.
I'm not entirely sure the rationale for usteer_band_steering_is_target to accept a local node, since it only access the fields within struct usteer_node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When choosing a better candidate for a client to roam to, consider the fact that the the client may also be band-steered to a different frequency after association.
If the new AP has
assoc_steeringenabled, this may cause the client to attempt association, and fail associating which results in a kick from the original AP. This will cause the client to lose its association with the ESS.