RTD redirect: fix 404 redirects #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now 404 uses static url prefix, rtd doesn't have this prefix, so links like https://openzfs.readthedocs.io/openzfs-docs/Getting%20Started/index.html (which existed in old rtd site) can't load js with redirects. So, just push redirect js inside 404 html page.
Member
Author
|
@alek-p could you push changes to RTD after this PR merged? Or how can I do it in future? |
alek-p
approved these changes
Dec 1, 2025
Contributor
I need to be able to create a webhook in GitHub to automate deployments which I don't have permissions to do. I can also add you as a mainter on RTD. What email should I use ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now 404 uses static url prefix, rtd doesn't
have this prefix, so links like
https://openzfs.readthedocs.io/openzfs-docs/Getting%20Started/index.html (which existed in old rtd site)
can't load js with redirects.
So, just push redirect js inside 404 html page.