Skip to content

Conversation

@camilamacedo86
Copy link
Contributor

Update golang CI lint to v2.7.2

motivation
Use: https://github.com/kubernetes-sigs/kube-api-linter

Copilot AI review requested due to automatic review settings December 19, 2025 10:34
@camilamacedo86 camilamacedo86 requested a review from a team as a code owner December 19, 2025 10:34
@netlify
Copy link

netlify bot commented Dec 19, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit f04f6fb
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/69452fa182d2510008535730
😎 Deploy Preview https://deploy-preview-2395--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates golangci-lint from v2.6.2 to v2.7.2 using the bingo dependency management tool. The update also includes an upgrade of bingo itself from v0.9 to v0.10, which brings improvements for cross-compilation support.

Key changes:

  • golangci-lint upgraded from v2.6.2 to v2.7.2
  • bingo tool upgraded from v0.9 to v0.10
  • Added cross-compilation support with GOHOSTOS/GOARCH/GOARM environment variables in build commands

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
.bingo/variables.env Updated bingo version comment and golangci-lint version variable
.bingo/golangci-lint.sum Added dependency checksums for new golangci-lint v2.7.2 and its transitive dependencies
.bingo/golangci-lint.mod Updated golangci-lint requirement to v2.7.2
.bingo/Variables.mk Updated bingo version, added GOHOSTOS/GOARCH/GOARM variables, and updated all build commands to support cross-compilation
.bingo/README.md Updated documentation for bingo usage and Go version requirements
.bingo/.gitignore Added pattern to ignore temporary sum files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.05%. Comparing base (cc8ed2b) to head (f04f6fb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2395      +/-   ##
==========================================
+ Coverage   68.79%   73.05%   +4.25%     
==========================================
  Files         100      100              
  Lines        7641     7641              
==========================================
+ Hits         5257     5582     +325     
+ Misses       1948     1623     -325     
  Partials      436      436              
Flag Coverage Δ
e2e 43.93% <ø> (+0.02%) ⬆️
experimental-e2e 48.77% <ø> (+35.09%) ⬆️
unit 57.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@camilamacedo86 camilamacedo86 changed the title 🌱 Update using bingo golang-ci 🌱 (bingo) Update golang-ci from v2.6.2 to v2.7.2 Dec 19, 2025
Copy link
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to combine this PR with PR where we really add kube-api-linter.

@camilamacedo86
Copy link
Contributor Author

I would suggest to combine this PR with PR where we really add kube-api-linter.

I strongly disagree.

The kube-api-linter is a long-term initiative. Adding it will require significant time to evaluate findings, discuss them, and gradually fix issues across our API.

This PR, on the other hand, is focused on keeping our Go CI up to date, which we should do continuously and independently of longer-term improvements.

For that reason, I don’t see a strong justification to block or merge this work together with the kube-api-linter PR.

@pedjak
Copy link
Contributor

pedjak commented Dec 19, 2025

For that reason, I don’t see a strong justification to block or merge this work together with the kube-api-linter PR.

ah, ok, I confused due the mentioned motivation in PR description.

Copy link
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2025
@perdasilva
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Dec 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit a85d6d1 into operator-framework:main Dec 19, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants