-
Notifications
You must be signed in to change notification settings - Fork 69
🌱 (bingo) Update golang-ci from v2.6.2 to v2.7.2 #2395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 (bingo) Update golang-ci from v2.6.2 to v2.7.2 #2395
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates golangci-lint from v2.6.2 to v2.7.2 using the bingo dependency management tool. The update also includes an upgrade of bingo itself from v0.9 to v0.10, which brings improvements for cross-compilation support.
Key changes:
- golangci-lint upgraded from v2.6.2 to v2.7.2
- bingo tool upgraded from v0.9 to v0.10
- Added cross-compilation support with GOHOSTOS/GOARCH/GOARM environment variables in build commands
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.bingo/variables.env |
Updated bingo version comment and golangci-lint version variable |
.bingo/golangci-lint.sum |
Added dependency checksums for new golangci-lint v2.7.2 and its transitive dependencies |
.bingo/golangci-lint.mod |
Updated golangci-lint requirement to v2.7.2 |
.bingo/Variables.mk |
Updated bingo version, added GOHOSTOS/GOARCH/GOARM variables, and updated all build commands to support cross-compilation |
.bingo/README.md |
Updated documentation for bingo usage and Go version requirements |
.bingo/.gitignore |
Added pattern to ignore temporary sum files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2395 +/- ##
==========================================
+ Coverage 68.79% 73.05% +4.25%
==========================================
Files 100 100
Lines 7641 7641
==========================================
+ Hits 5257 5582 +325
+ Misses 1948 1623 -325
Partials 436 436
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7d47ecd to
f04f6fb
Compare
pedjak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to combine this PR with PR where we really add kube-api-linter.
I strongly disagree. The kube-api-linter is a long-term initiative. Adding it will require significant time to evaluate findings, discuss them, and gradually fix issues across our API. This PR, on the other hand, is focused on keeping our Go CI up to date, which we should do continuously and independently of longer-term improvements. For that reason, I don’t see a strong justification to block or merge this work together with the kube-api-linter PR. |
ah, ok, I confused due the mentioned motivation in PR description. |
pedjak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a85d6d1
into
operator-framework:main
Update golang CI lint to v2.7.2
motivation
Use: https://github.com/kubernetes-sigs/kube-api-linter