Skip to content

New rpc service to attach/detach a controller to a namespace. #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VaibhavJMarvell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

New rpc service to attach/detach a controller to a namespace. #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions storage/v1alpha1/autogen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
- [NVMfRemoteControllerService](#opi_api-storage-v1-NVMfRemoteControllerService)

- [frontend_nvme_pcie.proto](#frontend_nvme_pcie-proto)
- [ControllerNVMeNamespaceRequest](#opi_api-storage-v1-ControllerNVMeNamespaceRequest)
- [CreateNVMeControllerRequest](#opi_api-storage-v1-CreateNVMeControllerRequest)
- [CreateNVMeNamespaceRequest](#opi_api-storage-v1-CreateNVMeNamespaceRequest)
- [CreateNVMeSubsystemRequest](#opi_api-storage-v1-CreateNVMeSubsystemRequest)
Expand Down Expand Up @@ -813,6 +814,23 @@ Back End (network-facing) APIs. NVMe/TCP and NVMe/RoCEv2 protocols are covered b



<a name="opi_api-storage-v1-ControllerNVMeNamespaceRequest"></a>

### ControllerNVMeNamespaceRequest



| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| subsystem | [string](#string) | | |
| controller | [opi_api.common.v1.ObjectKey](#opi_api-common-v1-ObjectKey) | | |
| nv_me_namespace_id | [opi_api.common.v1.ObjectKey](#opi_api-common-v1-ObjectKey) | | |






<a name="opi_api-storage-v1-CreateNVMeControllerRequest"></a>

### CreateNVMeControllerRequest
Expand Down Expand Up @@ -1409,6 +1427,8 @@ Front End (host-facing) APIs. Mostly used for NVMe/PCIe emulation and host prese
| ListNVMeNamespaces | [ListNVMeNamespacesRequest](#opi_api-storage-v1-ListNVMeNamespacesRequest) | [ListNVMeNamespacesResponse](#opi_api-storage-v1-ListNVMeNamespacesResponse) | |
| GetNVMeNamespace | [GetNVMeNamespaceRequest](#opi_api-storage-v1-GetNVMeNamespaceRequest) | [NVMeNamespace](#opi_api-storage-v1-NVMeNamespace) | |
| NVMeNamespaceStats | [NVMeNamespaceStatsRequest](#opi_api-storage-v1-NVMeNamespaceStatsRequest) | [NVMeNamespaceStatsResponse](#opi_api-storage-v1-NVMeNamespaceStatsResponse) | |
| AttachControllerNVMeNamespace | [ControllerNVMeNamespaceRequest](#opi_api-storage-v1-ControllerNVMeNamespaceRequest) | [.google.protobuf.Empty](#google-protobuf-Empty) | |
| DetachControllerNVMeNamespace | [ControllerNVMeNamespaceRequest](#opi_api-storage-v1-ControllerNVMeNamespaceRequest) | [.google.protobuf.Empty](#google-protobuf-Empty) | |



Expand Down
21 changes: 21 additions & 0 deletions storage/v1alpha1/frontend_nvme_pcie.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,20 @@ service FrontendNvmeService {
option (google.api.method_signature) = "name";
}
rpc NVMeNamespaceStats (NVMeNamespaceStatsRequest) returns (NVMeNamespaceStatsResponse) {}

rpc AttachControllerNVMeNamespace (ControllerNVMeNamespaceRequest) returns (google.protobuf.Empty) {
option (google.api.http) = {
post: "/v1/{subsystem=subsystemId/*/controller=nvmeControllerId/*}:attachControllerNvMeNamespace"
body: "*"
};
}

rpc DetachControllerNVMeNamespace (ControllerNVMeNamespaceRequest) returns (google.protobuf.Empty) {
option (google.api.http) = {
post: "/v1/{subsystem=subsystemId/*/controller=nvmeControllerId/*}:detachControllerNvMeNamespace"
body: "*"
};
}
}

message NVMeSubsystem {
Expand Down Expand Up @@ -398,6 +412,13 @@ message NVMeNamespaceStatsResponse {
VolumeStats stats = 2;
}

message ControllerNVMeNamespaceRequest {
string subsystem = 1 [
(google.api.field_behavior) = REQUIRED
];
common.v1.ObjectKey controller = 2 [(google.api.field_behavior) = REQUIRED];
common.v1.ObjectKey nv_me_namespace_id = 3 [(google.api.field_behavior) = REQUIRED];
}
// Namespace Administrative States
enum NVMeNamespacePciState {
// unspecified
Expand Down
84 changes: 84 additions & 0 deletions storage/v1alpha1/gen/cpp/frontend_nvme_pcie.grpc.pb.cc
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading