Require a Behavioral model and conformance tests#39
Open
prasunkapoor wants to merge 1 commit intoopiproject:mainfrom
Open
Require a Behavioral model and conformance tests#39prasunkapoor wants to merge 1 commit intoopiproject:mainfrom
prasunkapoor wants to merge 1 commit intoopiproject:mainfrom
Conversation
mestery
suggested changes
Nov 9, 2022
Contributor
mestery
left a comment
mestery
left a comment
There was a problem hiding this comment.
I don't think the behavioral model is tied to protobufs, so please move it up an indent to its own line after the protobuf stuff. Also, no need to capitalize it. And one last thing, make sure to wrap lines at 80 characters as the rest of the file is line-wrapped at 80 characters. Thanks!
prasunkapoor
force-pushed
the
pkapoor
branch
2 times, most recently
from
ac68d02 to
477c9f8
Compare
mestery
suggested changes
Nov 10, 2022
Signed-off-by: Prasun Kapoor <pkapoor@marvell.com>
prasunkapoor
force-pushed
the
pkapoor
branch
from
477c9f8 to
fa94593
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require a Behavioral model and conformance tests