v-editable-text directive, modeled after v-model
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft directive for contenteditable. Includes unit tests for the contenteditable-selection utility, but they're not currently passing. Also needs unit tests/integration tests for the directive itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft directive for contenteditable. Includes unit
tests for the contenteditable-selection utility, but they're
not currently passing. Also needs unit tests/integration tests
for the directive itself.
@jordangarcia Will you take a quick look at this before I open a PR to the main Vue repo? It's almost exactly the same as code you reviewed previously, but since you've committed to the main Vue repo before it'd be great to get some input from you. I'm having trouble with the unit tests at the moment, but I don't really have time to dig into the environment to debug what's going wrong.