Oracle migrator type #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
jawad-arb123
force-pushed
the
oracle_migrator_type
branch
from
c4737ba to
c5f8b8e
Compare
ting-lan-wang
approved these changes
Oct 28, 2025
Contributor
|
Looks good to me. Thanks! |
shelly-li-sl
approved these changes
Oct 28, 2025
Contributor
shelly-li-sl
left a comment
shelly-li-sl
left a comment
There was a problem hiding this comment.
Thanks for adding the tests @jawad-arb123 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a simplified
CreateType&DropType&hasTypemethods in the Oracle migrator.we need to specify the oracle Migrator to access the new methods
DB.Migrator().(oracle.Migrator)Fixes #86
we need to check if this is the right approach !!