-
Notifications
You must be signed in to change notification settings - Fork 78
Removed Identity client and related tools from database mcp server, and added the same to the identity server #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
96e279c to
9f7a59b
Compare
src/oci-identity-mcp-server/oracle/oci_identity_mcp_server/server.py
Outdated
Show resolved
Hide resolved
c08da9f to
b526db6
Compare
b526db6 to
b713ba8
Compare
|
Seems to work when testing it out locally |
46db3a6 to
ad900ce
Compare
ad900ce to
e3439f3
Compare
045d7fe to
a92f904
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, but some operational notes/concerns:
- I wasn't able to "create a database" or "create an autonomous database", but describing and interacting with an existing db worked fine.
- I could only convince one model to "list all my databases" (after a confirmation):
To list “all my databases,” do you want me to include every compartment (including subcompartments) and every subscribed region, and include both Autonomous Databases and DB System databases?
- Excessive context use (large server w/ many tools)
Description
Removed Identity client and related tools from database mcp server, and added the same to the identity server
Renamed database mcp server to match the conventions
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: