Skip to content

[WIP] Windows support. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
saul-jb wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[WIP] Windows support. #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3567ad4
Add windows to CI pipeline.
saul-jb Apr 12, 2024
537a2a9
Use named pipes on windows.
saul-jb Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
os: [ubuntu-latest, macos-latest, windows-latest]
node: [lts/*]
fail-fast: true
steps:
Expand Down
6 changes: 6 additions & 0 deletions packages/rpc/src/rpc-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import * as net from 'net'
import { platform } from 'os'
import Path from 'path'
import * as cborg from 'cborg'
import * as lp from 'it-length-prefixed'
import { pipe } from 'it-pipe'
Expand All @@ -17,6 +19,10 @@ export class RPCClient {
private readonly stream = pushable<JSONRPCRequest>({ objectMode: true })

constructor (path: string) {
if (platform() === 'win32') {
path = Path.join('\\\\.\\pipe', path)
}

this.socket = net.connect({ path })

this.rpc = new JSONRPCClient((request: JSONRPCRequest, options) => {
Expand Down
6 changes: 6 additions & 0 deletions packages/rpc/src/rpc-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import * as net from 'net'
import { platform } from 'os'
import Path from 'path'
import * as cborg from 'cborg'
import * as lp from 'it-length-prefixed'
import { pipe } from 'it-pipe'
Expand Down Expand Up @@ -32,6 +34,10 @@ export class RPCServer {
private readonly options: Required<RPCServerOptions>

constructor (path: string, options: RPCServerOptions = {}) {
if (platform() === 'win32') {
path = Path.join('\\\\.\\pipe', path)
}

this.path = path

this.options = {
Expand Down